[PR #3271] [MERGED] Add default trophy sound #3353

New issue

Closed

opened 2026-02-27 22:03:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3271
Author: @rainmakerv3
Created: 7/19/2025
Status: ✅ Merged
Merged: 7/21/2025
Merged by: @georgemoralis

Base: main ← Head: TrophySound

📝 Commits (4)

4ba4100 Add default trophy sound
4def7b3 delete include to removed folder
c840648 remove redundant conditions
925536c Change trophy sound - credit to Tlarok

📊 Changes

4 files changed (+44 additions, -3 deletions)

View changed files

📝 CMakeLists.txt (+1 -1)
📝 REUSE.toml (+1 -0)
📝 src/core/libraries/np_trophy/trophy_ui.cpp (+42 -2)
➕ src/images/trophy.wav (+0 -0)

📄 Description

Adds a default sound upon unlocking a trophy if no custom sound file exists.

Got the sound from here: https://pixabay.com/sound-effects/search/achievement/ so should be ok to use.

At first I thought this would need some kind of volume normalization because some games are much louder than others, but it seems to play at reasonable levels for both the loud game and soft game I tried so normalization seems to be unneeded.

The wav file is embedded in the binary similar to the trophy icons. For its source, i just put it in src/images with the other trophy files which may be kinda weird but I can't see a better location for it and probably doesn't justify a new folder.

EDIT: instead using a sound that was made by @tlarok . Thanks very much!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3271 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 7/19/2025 **Status:** ✅ Merged **Merged:** 7/21/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `TrophySound` --- ### 📝 Commits (4) - [`4ba4100`](https://github.com/shadps4-emu/shadPS4/commit/4ba41000558ce365d8a5f450c8928b86f951058a) Add default trophy sound - [`4def7b3`](https://github.com/shadps4-emu/shadPS4/commit/4def7b3b6e01d2cd663d99f013cbd0fe2482ec18) delete include to removed folder - [`c840648`](https://github.com/shadps4-emu/shadPS4/commit/c8406480d3b2eb5ba9b92be579064faa7db9e60d) remove redundant conditions - [`925536c`](https://github.com/shadps4-emu/shadPS4/commit/925536c523dc2dae188adf707600a4675f0530f7) Change trophy sound - credit to Tlarok ### 📊 Changes **4 files changed** (+44 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+1 -1) 📝 `REUSE.toml` (+1 -0) 📝 `src/core/libraries/np_trophy/trophy_ui.cpp` (+42 -2) ➕ `src/images/trophy.wav` (+0 -0) </details> ### 📄 Description Adds a default sound upon unlocking a trophy if no custom sound file exists. Got the sound from here: https://pixabay.com/sound-effects/search/achievement/ so should be ok to use. At first I thought this would need some kind of volume normalization because some games are much louder than others, but it seems to play at reasonable levels for both the loud game and soft game I tried so normalization seems to be unneeded. The wav file is embedded in the binary similar to the trophy icons. For its source, i just put it in src/images with the other trophy files which may be kinda weird but I can't see a better location for it and probably doesn't justify a new folder. EDIT: instead using a sound that was made by @tlarok . Thanks very much! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>