[PR #3252] [MERGED] Avoid clearing HTILE when shader contains address calculation #3337

New issue

Closed

opened 2026-02-27 22:03:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3252
Author: @raphaelthegreat
Created: 7/15/2025
Status: ✅ Merged
Merged: 7/15/2025
Merged by: @georgemoralis

Base: main ← Head: new-htile

📝 Commits (3)

edb8ac2 resource_tracking: Mark image as written when its used with atomics
dec6968 texture_cache: Remove meta registered flag
7ae49cd vk_rasterizer: Use xor as heuristic for HTILE clear

📊 Changes

8 files changed (+42 additions, -35 deletions)

View changed files

📝 src/shader_recompiler/frontend/instruction.h (+0 -2)
📝 src/shader_recompiler/info.h (+1 -0)
📝 src/shader_recompiler/ir/passes/resource_tracking_pass.cpp (+3 -2)
📝 src/shader_recompiler/ir/passes/shader_info_collection_pass.cpp (+3 -0)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+14 -5)
📝 src/video_core/texture_cache/image.h (+3 -4)
📝 src/video_core/texture_cache/texture_cache.cpp (+14 -22)
📝 src/video_core/texture_cache/texture_cache.h (+4 -0)

📄 Description

This is the second attempt to implement https://github.com/shadps4-emu/shadPS4/pull/3167
I'm open to other ideas but that was the best heuristic I could come up with that should work in most cases

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3252 **Author:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Created:** 7/15/2025 **Status:** ✅ Merged **Merged:** 7/15/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `new-htile` --- ### 📝 Commits (3) - [`edb8ac2`](https://github.com/shadps4-emu/shadPS4/commit/edb8ac290e26f10fadb30bc726cb9d2ef3e0aab2) resource_tracking: Mark image as written when its used with atomics - [`dec6968`](https://github.com/shadps4-emu/shadPS4/commit/dec6968f5a7893ac779756f199b62b6d0f9ba0d2) texture_cache: Remove meta registered flag - [`7ae49cd`](https://github.com/shadps4-emu/shadPS4/commit/7ae49cd06aa6466922c77026d3cbedfb30034b88) vk_rasterizer: Use xor as heuristic for HTILE clear ### 📊 Changes **8 files changed** (+42 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/instruction.h` (+0 -2) 📝 `src/shader_recompiler/info.h` (+1 -0) 📝 `src/shader_recompiler/ir/passes/resource_tracking_pass.cpp` (+3 -2) 📝 `src/shader_recompiler/ir/passes/shader_info_collection_pass.cpp` (+3 -0) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+14 -5) 📝 `src/video_core/texture_cache/image.h` (+3 -4) 📝 `src/video_core/texture_cache/texture_cache.cpp` (+14 -22) 📝 `src/video_core/texture_cache/texture_cache.h` (+4 -0) </details> ### 📄 Description This is the second attempt to implement https://github.com/shadps4-emu/shadPS4/pull/3167 I'm open to other ideas but that was the best heuristic I could come up with that should work in most cases --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>