[PR #3248] [MERGED] vk_instance: Remove usage of depth clamp control #3334

Closed
opened 2026-02-27 22:03:19 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3248
Author: @raphaelthegreat
Created: 7/15/2025
Status: Merged
Merged: 7/15/2025
Merged by: @georgemoralis

Base: mainHead: bad-amd


📝 Commits (1)

  • eefe8bd vk_instance: Remove usage of depth clamp control

📊 Changes

6 files changed (+6 additions, -98 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+5 -22)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+0 -3)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+0 -7)
📝 src/video_core/renderer_vulkan/vk_instance.h (+0 -6)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+1 -58)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.h (+0 -2)

📄 Description

AMD proprietary driver doesn't seem to properly implement the extension, not sure what the issue is as I can only test RADV which is fine

@StevenMiller123 Check if this fixes the regression, otherwise the extension itself might need to be excluded


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3248 **Author:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Created:** 7/15/2025 **Status:** ✅ Merged **Merged:** 7/15/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `bad-amd` --- ### 📝 Commits (1) - [`eefe8bd`](https://github.com/shadps4-emu/shadPS4/commit/eefe8bdfca2c49cef3ca49830c384ff93c06c028) vk_instance: Remove usage of depth clamp control ### 📊 Changes **6 files changed** (+6 additions, -98 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+5 -22) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+0 -3) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+0 -7) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+0 -6) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+1 -58) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.h` (+0 -2) </details> ### 📄 Description AMD proprietary driver doesn't seem to properly implement the extension, not sure what the issue is as I can only test RADV which is fine @StevenMiller123 Check if this fixes the regression, otherwise the extension itself might need to be excluded --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:03:19 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#3334
No description provided.