starred/shadPS4
1
0
Fork 0
mirror of https://github.com/shadps4-emu/shadPS4.git synced 2026-04-26 00:05:58 +03:00
Code Issues 120 Projects Releases 10 Packages Wiki Activity

[PR #3244] [MERGED] Ime lib fixes #3331

New issue
Closed
opened 2026-02-27 22:03:18 +03:00 by kerem · 0 comments
kerem commented 2026-02-27 22:03:18 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3244
Author: @w1naenator
Created: 7/14/2025
Status: ✅ Merged
Merged: 7/18/2025
Merged by: @georgemoralis

Base: main ← Head: ime-fixes

📝 Commits (10+)

📊 Changes

4 files changed (+432 additions, -51 deletions)

View changed files

📝 src/core/libraries/ime/ime.cpp (+206 -11)
📝 src/core/libraries/ime/ime.h (+4 -3)
📝 src/core/libraries/ime/ime_common.h (+174 -20)
📝 src/core/libraries/ime/ime_dialog.cpp (+48 -17)

📄 Description

  • Updated functions to consistently use the Error enum type for return values.
  • Added detailed logging to aid future IME/OSK development and debugging.
  • Now use OrbisUserServiceUserId (s32) and OrbisImeKeycodeState in relevant functions and structs.
  • Introduced a generic template method to generate full bitmasks for all Orbis flag-style enums, simplifying validation and mask creation.
  • Implemented additional parameter validations in sceImeOpen.
  • Added missing enums: OrbisDisableDevice, OrbisImeInputMethodState, OrbisImeInitExtKeyboardMode, OrbisImeKeycodeState, and other USB keyboard-related enums.
  • Fixed incorrect usage of format specifiers in calls to logging macros (LOG_*).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3244 **Author:** [@w1naenator](https://github.com/w1naenator) **Created:** 7/14/2025 **Status:** ✅ Merged **Merged:** 7/18/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `ime-fixes` --- ### 📝 Commits (10+) - [`ee14241`](https://github.com/shadps4-emu/shadPS4/commit/ee1424186e0be592a681f79859e468685389ed6a) IME fixes - [`0b81019`](https://github.com/shadps4-emu/shadPS4/commit/0b8101977c31eb490d78a41c4097ab7cbe81fbaa) Merge branch 'main' into ime-fixes - [`e5b84fc`](https://github.com/shadps4-emu/shadPS4/commit/e5b84fcfad457e8f363e2aab830a839d3970bc7c) Merge branch 'shadps4-emu:main' into ime-fixes - [`7881bd3`](https://github.com/shadps4-emu/shadPS4/commit/7881bd352bcbd916f84e320650b7e974e6cdff2d) Ime lib fixes - [`0d0ae7c`](https://github.com/shadps4-emu/shadPS4/commit/0d0ae7c72b3ffcc087da198e4fe7aeebbc851521) Merge branch 'ime-fixes' of https://github.com/w1naenator/shadPS4 into ime-fixes - [`6d1d760`](https://github.com/shadps4-emu/shadPS4/commit/6d1d760682637af3b663edce74c6d874fb1144dc) Data Type Fixes - [`2904b66`](https://github.com/shadps4-emu/shadPS4/commit/2904b66c4322de954360e5897b1a322ac96e986e) Merge branch 'main' into ime-fixes - [`bfd9302`](https://github.com/shadps4-emu/shadPS4/commit/bfd93028414034d9fcb722eb97b6e0571778d6fc) Fixed IDE warnings - [`cc25a70`](https://github.com/shadps4-emu/shadPS4/commit/cc25a7061e5b200929f56382fb829e1e38045852) Merge branch 'ime-fixes' of https://github.com/w1naenator/shadPS4 into ime-fixes - [`4b02d23`](https://github.com/shadps4-emu/shadPS4/commit/4b02d231e138f273475f609084ef4803a9e84f9f) Clang fixes ### 📊 Changes **4 files changed** (+432 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/ime/ime.cpp` (+206 -11) 📝 `src/core/libraries/ime/ime.h` (+4 -3) 📝 `src/core/libraries/ime/ime_common.h` (+174 -20) 📝 `src/core/libraries/ime/ime_dialog.cpp` (+48 -17) </details> ### 📄 Description - Updated functions to consistently use the Error enum type for return values. - Added detailed logging to aid future IME/OSK development and debugging. - Now use OrbisUserServiceUserId (s32) and OrbisImeKeycodeState in relevant functions and structs. - Introduced a generic template method to generate full bitmasks for all Orbis flag-style enums, simplifying validation and mask creation. - Implemented additional parameter validations in sceImeOpen. - Added missing enums: OrbisDisableDevice, OrbisImeInputMethodState, OrbisImeInitExtKeyboardMode, OrbisImeKeycodeState, and other USB keyboard-related enums. - Fixed incorrect usage of format specifiers in calls to logging macros (LOG_*). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:03:18 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
trophies_and_saves
user_and_settings
0.15.1branch_part6
Pre-release-shadPS4-2026-04-25-47f5cc14376c9d7694fc5728ed4ea98609ffe119
v.0.15.0
Pre-release-shadPS4-2026-02-26-19d2027105679d751328357d7c85cd83a84c9758
v.0.14.0
v.0.13.0
v.0.12.5
v.0.12.0
v.0.11.0
v.0.10.0
v.0.9.0
v.0.8.0
v.0.7.0
v.0.6.0
v.0.5.0
v.0.4.0
v.0.3.0
v.0.2.0
0.1.0
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels   
Bloodborne

   
bug

   
contributor wanted

   
documentation

   
enhancement

   
frontend

   
good first issue

   
help wanted

   
linux

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
release

   
verification progress
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#3331
No description provided.