[PR #3227] [MERGED] vk_rasterizer: Set render area to window scissor when no framebuffers are bound #3320

New issue

Closed

opened 2026-02-27 22:03:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3227
Author: @raphaelthegreat
Created: 7/10/2025
Status: ✅ Merged
Merged: 7/10/2025
Merged by: @georgemoralis

Base: main ← Head: renderarea

📝 Commits (1)

e2a79da vk_rasterizer: Set render area to max when no framebuffers are bound

📊 Changes

4 files changed (+16 additions, -9 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_instance.h (+11 -1)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+2 -0)
📝 src/video_core/renderer_vulkan/vk_scheduler.cpp (+1 -6)
📝 src/video_core/renderer_vulkan/vk_scheduler.h (+2 -2)

📄 Description

It is possible to have a draw call without any framebuffers attached, but still rely on all invocations inside scissor area being invoked (for example writing to storage image with gl_FragCoord coodinates). On main render area would be set to 1 in that case, replace that with the maximum render area, so it covers all of scissor rect

I vaguely remember Knack doing this but not sure

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3227 **Author:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Created:** 7/10/2025 **Status:** ✅ Merged **Merged:** 7/10/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `renderarea` --- ### 📝 Commits (1) - [`e2a79da`](https://github.com/shadps4-emu/shadPS4/commit/e2a79dabc3b3b955e69697a7445666b54ba6bc83) vk_rasterizer: Set render area to max when no framebuffers are bound ### 📊 Changes **4 files changed** (+16 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+11 -1) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+2 -0) 📝 `src/video_core/renderer_vulkan/vk_scheduler.cpp` (+1 -6) 📝 `src/video_core/renderer_vulkan/vk_scheduler.h` (+2 -2) </details> ### 📄 Description It is possible to have a draw call without any framebuffers attached, but still rely on all invocations inside scissor area being invoked (for example writing to storage image with gl_FragCoord coodinates). On main render area would be set to 1 in that case, replace that with the maximum render area, so it covers all of scissor rect I vaguely remember Knack doing this but not sure --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>