[PR #3223] [MERGED] Define S_TRAP as InstCategory::FlowControl and stub it #3316

New issue

Closed

opened 2026-02-27 22:03:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3223
Author: @kalaposfos13
Created: 7/10/2025
Status: ✅ Merged
Merged: 7/10/2025
Merged by: @georgemoralis

Base: main ← Head: s_trap

📝 Commits (1)

40ee410 Define S_TRAP as InstCategory::FlowControl

📊 Changes

2 files changed (+4 additions, -1 deletions)

View changed files

📝 src/shader_recompiler/frontend/format.cpp (+1 -1)
📝 src/shader_recompiler/frontend/translate/scalar_flow.cpp (+3 -0)

📄 Description

One of the shaders in SotC uses this, and it being undefined lead to an unreachable at translate.cpp:608 previously.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3223 **Author:** [@kalaposfos13](https://github.com/kalaposfos13) **Created:** 7/10/2025 **Status:** ✅ Merged **Merged:** 7/10/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `s_trap` --- ### 📝 Commits (1) - [`40ee410`](https://github.com/shadps4-emu/shadPS4/commit/40ee4104db32a3195ce51fff45efaf8f364cfb6d) Define S_TRAP as InstCategory::FlowControl ### 📊 Changes **2 files changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/format.cpp` (+1 -1) 📝 `src/shader_recompiler/frontend/translate/scalar_flow.cpp` (+3 -0) </details> ### 📄 Description One of the shaders in SotC uses this, and it being undefined lead to an unreachable at translate.cpp:608 previously. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>