[PR #3195] [CLOSED] Ime library fixes #3298

New issue

Closed

opened 2026-02-27 22:03:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3195
Author: @w1naenator
Created: 7/5/2025
Status: ❌ Closed

Base: main ← Head: ime-fixes

📝 Commits (2)

2b60d9b - Restructured the code for better clarity.
0e4b7e7 Update ime_common.h

📊 Changes

7 files changed (+221 additions, -49 deletions)

View changed files

📝 src/core/libraries/ime/ime.cpp (+3 -3)
📝 src/core/libraries/ime/ime.h (+9 -7)
📝 src/core/libraries/ime/ime_common.h (+169 -4)
📝 src/core/libraries/ime/ime_dialog.cpp (+9 -11)
📝 src/core/libraries/ime/ime_dialog.h (+29 -22)
📝 src/core/libraries/ime/ime_dialog_ui.cpp (+1 -1)
📝 src/core/libraries/ime/ime_ui.cpp (+1 -1)

📄 Description

Restructured the code for better clarity.
Added missing enums and structs.
Updated OrbisImeTextAreaProperty.
Fixed incorrect / incomplete OrbisImeEventParam.
Replaced OrbisImeDialogOption with OrbisImeOption.
Removed the incorrect OrbisImeDialogOption.
Fixed OrbisImeDialogParam.
Updated the sceImeOpen declaration to use extended parameters, but this is not yet implemented.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3195 **Author:** [@w1naenator](https://github.com/w1naenator) **Created:** 7/5/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `ime-fixes` --- ### 📝 Commits (2) - [`2b60d9b`](https://github.com/shadps4-emu/shadPS4/commit/2b60d9bb553710f235453baacb6295720109180b) - Restructured the code for better clarity. - [`0e4b7e7`](https://github.com/shadps4-emu/shadPS4/commit/0e4b7e75b989caf74598098228fea1e305dc56b2) Update ime_common.h ### 📊 Changes **7 files changed** (+221 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/ime/ime.cpp` (+3 -3) 📝 `src/core/libraries/ime/ime.h` (+9 -7) 📝 `src/core/libraries/ime/ime_common.h` (+169 -4) 📝 `src/core/libraries/ime/ime_dialog.cpp` (+9 -11) 📝 `src/core/libraries/ime/ime_dialog.h` (+29 -22) 📝 `src/core/libraries/ime/ime_dialog_ui.cpp` (+1 -1) 📝 `src/core/libraries/ime/ime_ui.cpp` (+1 -1) </details> ### 📄 Description - Restructured the code for better clarity. - Added missing enums and structs. - Updated OrbisImeTextAreaProperty. - Fixed incorrect / incomplete OrbisImeEventParam. - Replaced OrbisImeDialogOption with OrbisImeOption. - Removed the incorrect OrbisImeDialogOption. - Fixed OrbisImeDialogParam. - Updated the sceImeOpen declaration to use extended parameters, but this is not yet implemented. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>