[PR #3178] [MERGED] Readbacks proof of concept rebased #3287

New issue

Closed

opened 2026-02-27 22:03:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3178
Author: @raphaelthegreat
Created: 6/30/2025
Status: ✅ Merged
Merged: 7/1/2025
Merged by: @georgemoralis

Base: main ← Head: lazy-flush

📝 Commits (4)

53a48bd Readbacks proof of concept
0b410a1 liverpool: Use span for acb too
53519aa config: Add readbacks config option
bfa1c59 config: Log readbacks

📊 Changes

17 files changed (+375 additions, -186 deletions)

View changed files

📝 src/common/config.cpp (+11 -0)
📝 src/common/config.h (+2 -0)
📝 src/core/address_space.cpp (+4 -3)
📝 src/core/address_space.h (+1 -0)
📝 src/core/libraries/gnmdriver/gnmdriver.cpp (+1 -1)
📝 src/emulator.cpp (+1 -0)
📝 src/video_core/amdgpu/liverpool.cpp (+56 -42)
📝 src/video_core/amdgpu/liverpool.h (+28 -7)
📝 src/video_core/buffer_cache/buffer_cache.cpp (+136 -41)
📝 src/video_core/buffer_cache/buffer_cache.h (+22 -14)
📝 src/video_core/buffer_cache/memory_tracker.h (+8 -0)
📝 src/video_core/buffer_cache/region_definitions.h (+1 -3)
📝 src/video_core/buffer_cache/region_manager.h (+22 -38)
📝 src/video_core/page_manager.cpp (+62 -31)
📝 src/video_core/page_manager.h (+2 -3)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+16 -3)
📝 src/video_core/renderer_vulkan/vk_rasterizer.h (+2 -0)

📄 Description

The same as https://github.com/shadps4-emu/shadPS4/pull/2668 but rebased on new region manager and page manager implementations. Mostly opening so it can be compared with the readbacks-lite approach on correctness. There are also some optimizations I thought of to improve performance here, but will take time

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3178 **Author:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Created:** 6/30/2025 **Status:** ✅ Merged **Merged:** 7/1/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `lazy-flush` --- ### 📝 Commits (4) - [`53a48bd`](https://github.com/shadps4-emu/shadPS4/commit/53a48bdbcdb757f3fd33144a272e6f4908557760) Readbacks proof of concept - [`0b410a1`](https://github.com/shadps4-emu/shadPS4/commit/0b410a16adf3cf1a491879d11c8fbd399823a726) liverpool: Use span for acb too - [`53519aa`](https://github.com/shadps4-emu/shadPS4/commit/53519aa8ca8b0b75573d263e6704ca7df4ab2b92) config: Add readbacks config option - [`bfa1c59`](https://github.com/shadps4-emu/shadPS4/commit/bfa1c591a83f72c6892d421e6f449f52c9d8f536) config: Log readbacks ### 📊 Changes **17 files changed** (+375 additions, -186 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+11 -0) 📝 `src/common/config.h` (+2 -0) 📝 `src/core/address_space.cpp` (+4 -3) 📝 `src/core/address_space.h` (+1 -0) 📝 `src/core/libraries/gnmdriver/gnmdriver.cpp` (+1 -1) 📝 `src/emulator.cpp` (+1 -0) 📝 `src/video_core/amdgpu/liverpool.cpp` (+56 -42) 📝 `src/video_core/amdgpu/liverpool.h` (+28 -7) 📝 `src/video_core/buffer_cache/buffer_cache.cpp` (+136 -41) 📝 `src/video_core/buffer_cache/buffer_cache.h` (+22 -14) 📝 `src/video_core/buffer_cache/memory_tracker.h` (+8 -0) 📝 `src/video_core/buffer_cache/region_definitions.h` (+1 -3) 📝 `src/video_core/buffer_cache/region_manager.h` (+22 -38) 📝 `src/video_core/page_manager.cpp` (+62 -31) 📝 `src/video_core/page_manager.h` (+2 -3) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+16 -3) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.h` (+2 -0) </details> ### 📄 Description The same as https://github.com/shadps4-emu/shadPS4/pull/2668 but rebased on new region manager and page manager implementations. Mostly opening so it can be compared with the readbacks-lite approach on correctness. There are also some optimizations I thought of to improve performance here, but will take time --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>