[PR #3161] [MERGED] bit_array: Remove non const operator~ #3273

Closed
opened 2026-02-27 22:03:05 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3161
Author: @raphaelthegreat
Created: 6/26/2025
Status: Merged
Merged: 6/27/2025
Merged by: @squidbus

Base: mainHead: bit-pain


📝 Commits (1)

  • bdf1587 bit_array: Remove non const operator~

📊 Changes

1 file changed (+4 additions, -9 deletions)

View changed files

📝 src/common/bit_array.h (+4 -9)

📄 Description

This operator is never meant to actually operate on the object its prefixed, rather always make a copy.
This caused some debug pain trying to port read protects to the new region manager


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3161 **Author:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Created:** 6/26/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `bit-pain` --- ### 📝 Commits (1) - [`bdf1587`](https://github.com/shadps4-emu/shadPS4/commit/bdf1587827b68796c8f90c621de9b49c04e454ed) bit_array: Remove non const operator~ ### 📊 Changes **1 file changed** (+4 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/common/bit_array.h` (+4 -9) </details> ### 📄 Description This operator is never meant to actually operate on the object its prefixed, rather always make a copy. ~~This caused some debug pain trying to port read protects to the new region manager~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:03:05 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#3273
No description provided.