[PR #3157] [CLOSED] Some input code cleanup and fix ',' and '#' not working as input bindings by reverting symbol based naming #3269

New issue

Closed

opened 2026-02-27 22:03:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3157
Author: @kalaposfos13
Created: 6/25/2025
Status: ❌ Closed

Base: main ← Head: input-fix-fix

📝 Commits (3)

a64e806 Remove old ';' check as I don't think anyone is using this at all
3c77e9f Go back to the old naming scheme
9d2c0b4 Update documentation

📊 Changes

4 files changed (+55 additions, -58 deletions)

View changed files

📝 src/input/input_handler.cpp (+0 -5)
📝 src/input/input_handler.h (+39 -39)
📝 src/qt_gui/kbm_help_dialog.cpp (+11 -9)
📝 src/qt_gui/kbm_help_dialog.h (+5 -5)

📄 Description

Removes the ';' check at the ends of lines as it is not used by anyone at all as far as I know, and partially reverts #3109 as it made the two keys in the title not work due them already being a language element in my rebinding mini-language (comma is for separating binding combo elements like pad_up = w, lalt and hash is for comments).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3157 **Author:** [@kalaposfos13](https://github.com/kalaposfos13) **Created:** 6/25/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `input-fix-fix` --- ### 📝 Commits (3) - [`a64e806`](https://github.com/shadps4-emu/shadPS4/commit/a64e80673c6d9d0fef166d14260d43062584ea0c) Remove old ';' check as I don't think anyone is using this at all - [`3c77e9f`](https://github.com/shadps4-emu/shadPS4/commit/3c77e9fecc80f8d9f3d4c5d31f1a1e442152b5a6) Go back to the old naming scheme - [`9d2c0b4`](https://github.com/shadps4-emu/shadPS4/commit/9d2c0b459c4bdac30b7d6224a2a317452c1e0842) Update documentation ### 📊 Changes **4 files changed** (+55 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `src/input/input_handler.cpp` (+0 -5) 📝 `src/input/input_handler.h` (+39 -39) 📝 `src/qt_gui/kbm_help_dialog.cpp` (+11 -9) 📝 `src/qt_gui/kbm_help_dialog.h` (+5 -5) </details> ### 📄 Description Removes the ';' check at the ends of lines as it is not used by anyone at all as far as I know, and partially reverts #3109 as it made the two keys in the title not work due them already being a language element in my rebinding mini-language (comma is for separating binding combo elements like `pad_up = w, lalt` and hash is for comments). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>