[PR #3146] [MERGED] Kbm GUI - minor fixes #3261

New issue

Closed

opened 2026-02-27 22:03:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3146
Author: @rainmakerv3
Created: 6/22/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @georgemoralis

Base: main ← Head: KBM-fixes

📝 Commits (2)

b238e62 KBM Gui fixes
2b6ad96 remove unneeded activate window calls

📊 Changes

2 files changed (+89 additions, -69 deletions)

View changed files

📝 src/qt_gui/kbm_gui.cpp (+86 -68)
📝 src/qt_gui/kbm_gui.h (+3 -1)

📄 Description

Put wheel and mouse events under the if (EnableMapping) condition to ensure no extra inputs are captured.
Make GUI more responsive by emitting a signal to complete the mapping on key/mouse releases or unmodified wheel movements, instead of waiting for the per-second check
Bit of cleanup for things no longer used / unneeded

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3146 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 6/22/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `KBM-fixes` --- ### 📝 Commits (2) - [`b238e62`](https://github.com/shadps4-emu/shadPS4/commit/b238e62add21f6530756924a718cf6c70e5a6d51) KBM Gui fixes - [`2b6ad96`](https://github.com/shadps4-emu/shadPS4/commit/2b6ad9608cd5a7b3e1e20af3e387c7dd92cb84f6) remove unneeded activate window calls ### 📊 Changes **2 files changed** (+89 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/kbm_gui.cpp` (+86 -68) 📝 `src/qt_gui/kbm_gui.h` (+3 -1) </details> ### 📄 Description 1. Put wheel and mouse events under the if (EnableMapping) condition to ensure no extra inputs are captured. 2. Make GUI more responsive by emitting a signal to complete the mapping on key/mouse releases or unmodified wheel movements, instead of waiting for the per-second check 3. Bit of cleanup for things no longer used / unneeded --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>