[PR #3144] [MERGED] Controller Remapping GUI v2 #3260

New issue

Closed

opened 2026-02-27 22:03:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3144
Author: @rainmakerv3
Created: 6/22/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @kalaposfos13

Base: main ← Head: GUI-v2

📝 Commits (10+)

cbf08f7 Remapping GUI V2 - initial commit
71bca8b Unmap button with escape key
5430ca0 Allow combination inputs
b74eb79 Use separate class for SDL event signals so that i can work with the SDL window event loop
db65bf4 Automatically pause game when GUI open to better manage event queue
cd4931b Move sd;_gamepad_added event from remap object to GUI object to avoid conflicts with sdl window
86be802 Use signals on button/trigger to release to make GUI more responsive
8b08e2b pause game while KBM window is open for consistency
7d14392 don't check gamepad when game is running to avoid conflicts
134ae3e Block all other sdl events instead of pausing game, automatic parse inputs after saving

📊 Changes

11 files changed (+1198 additions, -605 deletions)

View changed files

📝 CMakeLists.txt (+2 -0)
📝 src/qt_gui/control_settings.cpp (+632 -281)
📝 src/qt_gui/control_settings.h (+43 -27)
📝 src/qt_gui/control_settings.ui (+392 -284)
📝 src/qt_gui/kbm_gui.cpp (+33 -9)
📝 src/qt_gui/kbm_gui.h (+5 -1)
📝 src/qt_gui/main_window.cpp (+6 -3)
📝 src/qt_gui/main_window.h (+2 -0)
➕ src/qt_gui/sdl_event_wrapper.cpp (+47 -0)
➕ src/qt_gui/sdl_event_wrapper.h (+25 -0)
📝 src/sdl_window.cpp (+11 -0)

📄 Description

Re-did the controller remapping GUI to be similar to the KBM GUI, it now listens for controller inputs instead of choosing items from a drop-down box.

Also to make it more consistent with the KBM GUI, the selections now represent inputs instead of outputs.

For now, controller only be remapped while a game in not running (so as to simplify SDL event loop handling).

Have not been able to test a lot, would be good to get a couple testers.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3144 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 6/22/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@kalaposfos13](https://github.com/kalaposfos13) **Base:** `main` ← **Head:** `GUI-v2` --- ### 📝 Commits (10+) - [`cbf08f7`](https://github.com/shadps4-emu/shadPS4/commit/cbf08f7f8856b836370afa73229be71eb39eb921) Remapping GUI V2 - initial commit - [`71bca8b`](https://github.com/shadps4-emu/shadPS4/commit/71bca8be8baeb3d2e9b11c8ef8e792f0db053bad) Unmap button with escape key - [`5430ca0`](https://github.com/shadps4-emu/shadPS4/commit/5430ca00fe8cdf30b19fd7fbfbdde5a1872d2a6e) Allow combination inputs - [`b74eb79`](https://github.com/shadps4-emu/shadPS4/commit/b74eb796fe7e13a0b2126a82e96c02b8212eac49) Use separate class for SDL event signals so that i can work with the SDL window event loop - [`db65bf4`](https://github.com/shadps4-emu/shadPS4/commit/db65bf48c407bb1834760ddde05b0eb82fe9967e) Automatically pause game when GUI open to better manage event queue - [`cd4931b`](https://github.com/shadps4-emu/shadPS4/commit/cd4931b16f97a353ad7557bf391ef35f6a4891c1) Move sd;_gamepad_added event from remap object to GUI object to avoid conflicts with sdl window - [`86be802`](https://github.com/shadps4-emu/shadPS4/commit/86be80222301fce757928ff68795f1aca894c3ca) Use signals on button/trigger to release to make GUI more responsive - [`8b08e2b`](https://github.com/shadps4-emu/shadPS4/commit/8b08e2b38215d1d443f5791c9a11eab0a051e9e0) pause game while KBM window is open for consistency - [`7d14392`](https://github.com/shadps4-emu/shadPS4/commit/7d1439287491381accc0706f5315c5f842466a8b) don't check gamepad when game is running to avoid conflicts - [`134ae3e`](https://github.com/shadps4-emu/shadPS4/commit/134ae3e9976bbe1d5ded041ab3d98bb4081aadc7) Block all other sdl events instead of pausing game, automatic parse inputs after saving ### 📊 Changes **11 files changed** (+1198 additions, -605 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -0) 📝 `src/qt_gui/control_settings.cpp` (+632 -281) 📝 `src/qt_gui/control_settings.h` (+43 -27) 📝 `src/qt_gui/control_settings.ui` (+392 -284) 📝 `src/qt_gui/kbm_gui.cpp` (+33 -9) 📝 `src/qt_gui/kbm_gui.h` (+5 -1) 📝 `src/qt_gui/main_window.cpp` (+6 -3) 📝 `src/qt_gui/main_window.h` (+2 -0) ➕ `src/qt_gui/sdl_event_wrapper.cpp` (+47 -0) ➕ `src/qt_gui/sdl_event_wrapper.h` (+25 -0) 📝 `src/sdl_window.cpp` (+11 -0) </details> ### 📄 Description Re-did the controller remapping GUI to be similar to the KBM GUI, it now listens for controller inputs instead of choosing items from a drop-down box. Also to make it more consistent with the KBM GUI, the selections now represent inputs instead of outputs. For now, controller only be remapped while a game in not running (so as to simplify SDL event loop handling). Have not been able to test a lot, would be good to get a couple testers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>