[PR #3139] [CLOSED] Revert "Handle immediate inline samplers (#3015)" #3255

New issue

Closed

opened 2026-02-27 22:03:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3139
Author: @kalaposfos13
Created: 6/21/2025
Status: ❌ Closed

Base: main ← Head: revert-3015

📝 Commits (1)

15f5938 Revert "Handle immediate inline samplers (#3015)"

📊 Changes

7 files changed (+38 additions, -54 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+1 -6)
📝 src/shader_recompiler/frontend/translate/vector_memory.cpp (+3 -6)
📝 src/shader_recompiler/info.h (+3 -10)
📝 src/shader_recompiler/ir/ir_emitter.cpp (+3 -3)
📝 src/shader_recompiler/ir/ir_emitter.h (+1 -2)
📝 src/shader_recompiler/ir/opcodes.inc (+1 -1)
📝 src/shader_recompiler/ir/passes/resource_tracking_pass.cpp (+26 -26)

📄 Description

This PR caused a regression in Gravity Rush Remastered downgrading it from playable to menus and STRANGER OF PARADISE FINAL FANTASY ORIGIN, and since no solution has been found by @mikusp or anyone else so far, a proposal to revert it until a fix exists has been made.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3139 **Author:** [@kalaposfos13](https://github.com/kalaposfos13) **Created:** 6/21/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `revert-3015` --- ### 📝 Commits (1) - [`15f5938`](https://github.com/shadps4-emu/shadPS4/commit/15f593865b3d3c24a7a35a9bcd07ef1873c8ad4b) Revert "Handle immediate inline samplers (#3015)" ### 📊 Changes **7 files changed** (+38 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+1 -6) 📝 `src/shader_recompiler/frontend/translate/vector_memory.cpp` (+3 -6) 📝 `src/shader_recompiler/info.h` (+3 -10) 📝 `src/shader_recompiler/ir/ir_emitter.cpp` (+3 -3) 📝 `src/shader_recompiler/ir/ir_emitter.h` (+1 -2) 📝 `src/shader_recompiler/ir/opcodes.inc` (+1 -1) 📝 `src/shader_recompiler/ir/passes/resource_tracking_pass.cpp` (+26 -26) </details> ### 📄 Description This PR caused a regression in Gravity Rush Remastered downgrading it from playable to menus and STRANGER OF PARADISE FINAL FANTASY ORIGIN, and since no solution has been found by @mikusp or anyone else so far, a proposal to revert it until a fix exists has been made. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>