[PR #3119] [MERGED] QT save fixes II #3239

Closed
opened 2026-02-27 22:02:57 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3119
Author: @georgemoralis
Created: 6/19/2025
Status: Merged
Merged: 6/20/2025
Merged by: @georgemoralis

Base: mainHead: qtsaves2


📝 Commits (10+)

  • c9a117c added recentFiles save/load
  • 1a31c9e Merge branch 'main' into qtsaves2
  • 5a331f7 gui language
  • 955dd2a Merge branch 'main' into qtsaves2
  • dd5a138 fixups for language
  • 5750448 fixed language issue with savedata (it was saving based on gui language and not on console language)
  • 22cde27 clang fix
  • a9f6af8 Merge branch 'main' into qtsaves2
  • fb7285b Merge branch 'main' into qtsaves2
  • 23446ff elf dirs added

📊 Changes

20 files changed (+185 additions, -263 deletions)

View changed files

📝 src/common/config.cpp (+0 -93)
📝 src/common/config.h (+71 -88)
📝 src/core/libraries/save_data/save_instance.cpp (+21 -21)
📝 src/emulator.cpp (+1 -4)
📝 src/qt_gui/about_dialog.cpp (+4 -3)
📝 src/qt_gui/about_dialog.h (+3 -1)
📝 src/qt_gui/elf_viewer.cpp (+9 -7)
📝 src/qt_gui/elf_viewer.h (+3 -2)
📝 src/qt_gui/game_grid_frame.cpp (+2 -1)
📝 src/qt_gui/game_list_frame.cpp (+2 -1)
📝 src/qt_gui/gui_context_menus.h (+4 -2)
📝 src/qt_gui/gui_settings.h (+6 -0)
📝 src/qt_gui/main_window.cpp (+29 -32)
📝 src/qt_gui/main_window.h (+1 -1)
📝 src/qt_gui/settings.cpp (+14 -0)
📝 src/qt_gui/settings.h (+2 -0)
📝 src/qt_gui/settings_dialog.cpp (+2 -1)
📝 src/qt_gui/settings_dialog.h (+1 -1)
📝 src/qt_gui/trophy_viewer.cpp (+6 -4)
📝 src/qt_gui/trophy_viewer.h (+4 -1)

📄 Description

This can also be an example of how to fix the saves of favourites for #2649

  1. Added recent files saves to qt save file
  2. gui language selection
  3. FIX: savedata was using gui language and not console language

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3119 **Author:** [@georgemoralis](https://github.com/georgemoralis) **Created:** 6/19/2025 **Status:** ✅ Merged **Merged:** 6/20/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `qtsaves2` --- ### 📝 Commits (10+) - [`c9a117c`](https://github.com/shadps4-emu/shadPS4/commit/c9a117c95cd95e8497b3a3a79c4a0681ee5715c3) added recentFiles save/load - [`1a31c9e`](https://github.com/shadps4-emu/shadPS4/commit/1a31c9e4dded2e2b1f2d17e4e7a54d8b722c620d) Merge branch 'main' into qtsaves2 - [`5a331f7`](https://github.com/shadps4-emu/shadPS4/commit/5a331f755fdb4bbddf05fec02af293a2a60f848a) gui language - [`955dd2a`](https://github.com/shadps4-emu/shadPS4/commit/955dd2ad65f93bc72ab6f8093ec19dab41783d72) Merge branch 'main' into qtsaves2 - [`dd5a138`](https://github.com/shadps4-emu/shadPS4/commit/dd5a138da98a8f61506ef3de248acdc5b61f30ba) fixups for language - [`5750448`](https://github.com/shadps4-emu/shadPS4/commit/57504483e8c46a25d1a024f5b3efa67d4088b3b4) fixed language issue with savedata (it was saving based on gui language and not on console language) - [`22cde27`](https://github.com/shadps4-emu/shadPS4/commit/22cde2798651fb360fde3e34a7dad75862e87a7d) clang fix - [`a9f6af8`](https://github.com/shadps4-emu/shadPS4/commit/a9f6af8a241aa6ab2f8a1910b0d8b6f765d3f7e5) Merge branch 'main' into qtsaves2 - [`fb7285b`](https://github.com/shadps4-emu/shadPS4/commit/fb7285b4f5f5cf4bb89b2e2ae95fd21645b3ce97) Merge branch 'main' into qtsaves2 - [`23446ff`](https://github.com/shadps4-emu/shadPS4/commit/23446ff286fdca311fda154dbf3cd8b8392d7af6) elf dirs added ### 📊 Changes **20 files changed** (+185 additions, -263 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+0 -93) 📝 `src/common/config.h` (+71 -88) 📝 `src/core/libraries/save_data/save_instance.cpp` (+21 -21) 📝 `src/emulator.cpp` (+1 -4) 📝 `src/qt_gui/about_dialog.cpp` (+4 -3) 📝 `src/qt_gui/about_dialog.h` (+3 -1) 📝 `src/qt_gui/elf_viewer.cpp` (+9 -7) 📝 `src/qt_gui/elf_viewer.h` (+3 -2) 📝 `src/qt_gui/game_grid_frame.cpp` (+2 -1) 📝 `src/qt_gui/game_list_frame.cpp` (+2 -1) 📝 `src/qt_gui/gui_context_menus.h` (+4 -2) 📝 `src/qt_gui/gui_settings.h` (+6 -0) 📝 `src/qt_gui/main_window.cpp` (+29 -32) 📝 `src/qt_gui/main_window.h` (+1 -1) 📝 `src/qt_gui/settings.cpp` (+14 -0) 📝 `src/qt_gui/settings.h` (+2 -0) 📝 `src/qt_gui/settings_dialog.cpp` (+2 -1) 📝 `src/qt_gui/settings_dialog.h` (+1 -1) 📝 `src/qt_gui/trophy_viewer.cpp` (+6 -4) 📝 `src/qt_gui/trophy_viewer.h` (+4 -1) </details> ### 📄 Description This can also be an example of how to fix the saves of favourites for #2649 1. Added recent files saves to qt save file 2. gui language selection 3. FIX: savedata was using gui language and not console language --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:02:57 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#3239
No description provided.