[PR #3110] [MERGED] shader_recompiler: Fix some shared memory accesses when workgroup struct is omitted. #3234

New issue

Closed

opened 2026-02-27 22:02:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3110
Author: @squidbus
Created: 6/17/2025
Status: ✅ Merged
Merged: 6/17/2025
Merged by: @squidbus

Base: main ← Head: fix-shared-4

📝 Commits (1)

5240852 shader_recompiler: Fix some shared memory accesses when workgroup struct is omitted.

📊 Changes

3 files changed (+17 additions, -30 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv_atomic.cpp (+3 -6)
📝 src/shader_recompiler/backend/spirv/emit_spirv_shared_memory.cpp (+6 -24)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.h (+8 -0)

📄 Description

Fix-up on https://github.com/shadps4-emu/shadPS4/pull/3106:

Some places were missed for updating the shared memory access chains.
Consolidated shared access emit into one helper function to reduce duplication.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3110 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 6/17/2025 **Status:** ✅ Merged **Merged:** 6/17/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `fix-shared-4` --- ### 📝 Commits (1) - [`5240852`](https://github.com/shadps4-emu/shadPS4/commit/5240852ae3ba67f9d5ebf86b1b913d3d60f52a48) shader_recompiler: Fix some shared memory accesses when workgroup struct is omitted. ### 📊 Changes **3 files changed** (+17 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv_atomic.cpp` (+3 -6) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_shared_memory.cpp` (+6 -24) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.h` (+8 -0) </details> ### 📄 Description Fix-up on https://github.com/shadps4-emu/shadPS4/pull/3106: * Some places were missed for updating the shared memory access chains. * Consolidated shared access emit into one helper function to reduce duplication. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>