[PR #3107] [MERGED] Enable sampleRateShading #3230

New issue

Closed

opened 2026-02-27 22:02:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3107
Author: @mikusp
Created: 6/16/2025
Status: ✅ Merged
Merged: 6/16/2025
Merged by: @georgemoralis

Base: main ← Head: sample_rate_shading

📝 Commits (1)

8aaa937 Enable sampleRateShading

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_instance.cpp (+1 -0)

📄 Description

Fixes validation error introduced by https://github.com/shadps4-emu/shadPS4/pull/3103

[Render.Vulkan] <Error> vk_platform.cpp:56 DebugUtilsCallback: VUID-VkShaderModuleCreateInfo-pCode-08740: vkCreateShaderModule(): SPIR-V Capability SampleRateShading was declared, but one of the following requirements is required (VkPhysicalDeviceFeatures::sampleRateShading).
The Vulkan spec states: If pCode is a pointer to SPIR-V code, and pCode declares any of the capabilities listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://docs.vulkan.org/spec/latest/chapters/shaders.html#VUID-VkShaderModuleCreateInfo-pCode-08740)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3107 **Author:** [@mikusp](https://github.com/mikusp) **Created:** 6/16/2025 **Status:** ✅ Merged **Merged:** 6/16/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `sample_rate_shading` --- ### 📝 Commits (1) - [`8aaa937`](https://github.com/shadps4-emu/shadPS4/commit/8aaa9376c8cc94e1d62650f1c611ccf5c324df00) Enable sampleRateShading ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+1 -0) </details> ### 📄 Description Fixes validation error introduced by https://github.com/shadps4-emu/shadPS4/pull/3103 ``` [Render.Vulkan] <Error> vk_platform.cpp:56 DebugUtilsCallback: VUID-VkShaderModuleCreateInfo-pCode-08740: vkCreateShaderModule(): SPIR-V Capability SampleRateShading was declared, but one of the following requirements is required (VkPhysicalDeviceFeatures::sampleRateShading). The Vulkan spec states: If pCode is a pointer to SPIR-V code, and pCode declares any of the capabilities listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://docs.vulkan.org/spec/latest/chapters/shaders.html#VUID-VkShaderModuleCreateInfo-pCode-08740) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>