[PR #3098] [MERGED] Qt: If duplicate unique inputs found, show which buttons have duplicates #3224

New issue

Closed

opened 2026-02-27 22:02:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3098
Author: @rainmakerv3
Created: 6/14/2025
Status: ✅ Merged
Merged: 6/15/2025
Merged by: @georgemoralis

Base: main ← Head: KBM-conflict

📝 Commits (4)

65227f8 If duplicate unique inputs found, show which buttons have duplicates
b2ff918 remove duplicate button from list
a0a439c cleanup
3b76976 Set clang-format off for long translatable string

📊 Changes

1 file changed (+27 additions, -10 deletions)

View changed files

📝 src/qt_gui/kbm_gui.cpp (+27 -10)

📄 Description

The KBM GUI does not allow the same unique input to be used for multiple outputs (this breaks the input engine). However, currently it does not show which particular inputs have duplicate mappings so the user may have a difficult time trying to find them.

This PR, upon detecting duplicate inputs, gets the button names and duplicate input strings and displays them in the corresponding error message:

Also removes a duplicated entry in the buttons QList

PR:

Main:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3098 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 6/14/2025 **Status:** ✅ Merged **Merged:** 6/15/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `KBM-conflict` --- ### 📝 Commits (4) - [`65227f8`](https://github.com/shadps4-emu/shadPS4/commit/65227f8bb359b7738e16948fe3f30f2565dac692) If duplicate unique inputs found, show which buttons have duplicates - [`b2ff918`](https://github.com/shadps4-emu/shadPS4/commit/b2ff9180ea0fb49da47b927a2d9e05812baa6c4f) remove duplicate button from list - [`a0a439c`](https://github.com/shadps4-emu/shadPS4/commit/a0a439cd55c6d2975e409bdf31991232f78f8f3d) cleanup - [`3b76976`](https://github.com/shadps4-emu/shadPS4/commit/3b7697699e86121e16c11730cc3e82fe5613ff4c) Set clang-format off for long translatable string ### 📊 Changes **1 file changed** (+27 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/kbm_gui.cpp` (+27 -10) </details> ### 📄 Description The KBM GUI does not allow the same unique input to be used for multiple outputs (this breaks the input engine). However, currently it does not show which particular inputs have duplicate mappings so the user may have a difficult time trying to find them. This PR, upon detecting duplicate inputs, gets the button names and duplicate input strings and displays them in the corresponding error message: Also removes a duplicated entry in the buttons QList PR: ![image](https://github.com/user-attachments/assets/3a5a7cec-d473-4993-8fce-237f7f15a275) Main: ![image](https://github.com/user-attachments/assets/64819b12-1e84-4d5a-8388-7269bda46f18) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>