[PR #3042] [MERGED] QT: AutoUpdate - Fix Changelog Error #3172

New issue

Closed

opened 2026-02-27 22:02:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3042
Author: @DanielSvoboda
Created: 6/5/2025
Status: ✅ Merged
Merged: 6/5/2025
Merged by: @georgemoralis

Base: main ← Head: Fix-Changelog-Error

📝 Commits (1)

0d933b2 QT: AutoUpdate - Fix Changelog Error

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 .github/workflows/build.yml (+3 -3)
📝 src/qt_gui/check_update.cpp (+3 -3)

📄 Description

Sometimes when trying to show the changelog, this print error appears, this PR fixes it

Technically speaking, two hashes were compared:
the hash of the executable: 88f6cb4d4197748c2dde637e3c9340823193228c

and
the hash of the latest pre-release: 23710f3

but the pre-release only had the simplified hash with 7 characters, and the executable had the full hash of 41 characters.
And sometimes GitHub simply couldn't make this comparison using the short hash.

Now the 'Tags' of the pre-release will contain the full hash, as in the image below:

I didn't change the 'name' of the pre-release, just the 'Tags', as this is the information that the github api returns.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3042 **Author:** [@DanielSvoboda](https://github.com/DanielSvoboda) **Created:** 6/5/2025 **Status:** ✅ Merged **Merged:** 6/5/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `Fix-Changelog-Error` --- ### 📝 Commits (1) - [`0d933b2`](https://github.com/shadps4-emu/shadPS4/commit/0d933b24e2586d58e1de38c8e9039c56f45d1d9b) QT: AutoUpdate - Fix Changelog Error ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+3 -3) 📝 `src/qt_gui/check_update.cpp` (+3 -3) </details> ### 📄 Description Sometimes when trying to show the changelog, this print error appears, this PR fixes it ![image](https://github.com/user-attachments/assets/57c6aa01-7512-4850-a191-ef84c3e0ddfe) ---- Technically speaking, two hashes were compared: the hash of the executable: `88f6cb4d4197748c2dde637e3c9340823193228c` and the hash of the latest pre-release: `23710f3` but the pre-release only had the simplified hash with 7 characters, and the executable had the full hash of 41 characters. And sometimes GitHub simply couldn't make this comparison using the short hash. Now the 'Tags' of the pre-release will contain the full hash, as in the image below: ![image](https://github.com/user-attachments/assets/15640151-e51e-4842-ad16-f6c2fddfeafe) I didn't change the 'name' of the pre-release, just the 'Tags', as this is the information that the github api returns. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>