[PR #3041] [MERGED] libSceZlib: Fix Queues #3171

New issue

Closed

opened 2026-02-27 22:02:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3041
Author: @StevenMiller123
Created: 6/5/2025
Status: ✅ Merged
Merged: 6/5/2025
Merged by: @georgemoralis

Base: main ← Head: zlib-fix

📝 Commits (1)

4ae425b Fix request queues in libSceZlib

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/core/libraries/zlib/zlib.cpp (+2 -2)

📄 Description

Queues are a FIFO data structure, so pop() removes the front, not the end. Therefore, we should be getting from the front of a queue before calling pop(), not the back.

Fixing this issue fixes a strange memory issue observed in Rise of the Tomb Raider (CUSA09193), though the game doesn't get much further yet.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3041 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 6/5/2025 **Status:** ✅ Merged **Merged:** 6/5/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `zlib-fix` --- ### 📝 Commits (1) - [`4ae425b`](https://github.com/shadps4-emu/shadPS4/commit/4ae425bb2dd171271578fdc59bcea5cd1327a616) Fix request queues in libSceZlib ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/zlib/zlib.cpp` (+2 -2) </details> ### 📄 Description Queues are a FIFO data structure, so pop() removes the front, not the end. Therefore, we should be getting from the front of a queue before calling pop(), not the back. Fixing this issue fixes a strange memory issue observed in Rise of the Tomb Raider (CUSA09193), though the game doesn't get much further yet. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>