[PR #2996] [CLOSED] Predication and occlusion queries #3136

New issue

Closed

opened 2026-02-27 22:02:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2996
Author: @mikusp
Created: 5/27/2025
Status: ❌ Closed

Base: main ← Head: predication

📝 Commits (10+)

5eda82b Enable VK_EXT_conditional_rendering
d2ed730 Define PM4 SetPredication command
0543f1f Handle predication PM4 commands
abdc557 Handle occlusion query commands
cb69968 Run occlusion queries when requested by a game
ab9254f Fix Vulkan validation errors with using queries
34f0f03 Use conditional rendering based on the occlusion query results
979e174 clang-format
4a49e2b Include a barrier for conditional rendering read
c52778a Fixes

📊 Changes

52 files changed (+1423 additions, -339 deletions)

View changed files

📝 CMakeLists.txt (+4 -0)
📝 documents/building-linux.md (+1 -1)
📝 src/common/config.cpp (+13 -1)
📝 src/common/config.h (+3 -1)
📝 src/common/logging/filter.cpp (+2 -0)
📝 src/common/logging/types.h (+2 -0)
📝 src/common/scm_rev.cpp.in (+23 -0)
📝 src/common/scm_rev.h (+4 -0)
📝 src/core/libraries/companion/companion_error.h (+7 -0)
➕ src/core/libraries/companion/companion_util.cpp (+72 -0)
➕ src/core/libraries/companion/companion_util.h (+33 -0)
📝 src/core/libraries/kernel/memory.cpp (+72 -38)
📝 src/core/libraries/kernel/memory.h (+9 -9)
📝 src/core/libraries/kernel/threads/pthread.cpp (+27 -4)
📝 src/core/libraries/kernel/threads/pthread_attr.cpp (+2 -0)
📝 src/core/libraries/libs.cpp (+4 -0)
📝 src/core/libraries/network/net.cpp (+139 -7)
📝 src/core/libraries/network/net.h (+4 -0)
📝 src/core/libraries/np_manager/np_manager.cpp (+25 -11)
📝 src/core/libraries/np_manager/np_manager.h (+8 -1)

...and 32 more files

📄 Description

Needs more testing, I've tried with Ni no Kuni II but it makes no visible difference there.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2996 **Author:** [@mikusp](https://github.com/mikusp) **Created:** 5/27/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `predication` --- ### 📝 Commits (10+) - [`5eda82b`](https://github.com/shadps4-emu/shadPS4/commit/5eda82bbab95a7f608c7f8e4a8615d0223bb1d53) Enable VK_EXT_conditional_rendering - [`d2ed730`](https://github.com/shadps4-emu/shadPS4/commit/d2ed73005ea12a7ec4ab5d729b917dae797bdbf0) Define PM4 SetPredication command - [`0543f1f`](https://github.com/shadps4-emu/shadPS4/commit/0543f1fd6da53217343d09cbe765c357d960104c) Handle predication PM4 commands - [`abdc557`](https://github.com/shadps4-emu/shadPS4/commit/abdc55726210df2f45930d5298ba5161b2201018) Handle occlusion query commands - [`cb69968`](https://github.com/shadps4-emu/shadPS4/commit/cb69968d47e695999d1e2275385ee4e4f750ccc1) Run occlusion queries when requested by a game - [`ab9254f`](https://github.com/shadps4-emu/shadPS4/commit/ab9254f21a58e86e02b10c7f65d33f030c063828) Fix Vulkan validation errors with using queries - [`34f0f03`](https://github.com/shadps4-emu/shadPS4/commit/34f0f03f99758f4fede636aa6e597f452926c693) Use conditional rendering based on the occlusion query results - [`979e174`](https://github.com/shadps4-emu/shadPS4/commit/979e17459ff337fbf2ad5084e13e30ed2ac889a0) clang-format - [`4a49e2b`](https://github.com/shadps4-emu/shadPS4/commit/4a49e2bb31d83ca5c4d20ae9a828daecf99a9dd9) Include a barrier for conditional rendering read - [`c52778a`](https://github.com/shadps4-emu/shadPS4/commit/c52778a2d9cc3ed7292fdbe8e36d7b98d7f1c52c) Fixes ### 📊 Changes **52 files changed** (+1423 additions, -339 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+4 -0) 📝 `documents/building-linux.md` (+1 -1) 📝 `src/common/config.cpp` (+13 -1) 📝 `src/common/config.h` (+3 -1) 📝 `src/common/logging/filter.cpp` (+2 -0) 📝 `src/common/logging/types.h` (+2 -0) 📝 `src/common/scm_rev.cpp.in` (+23 -0) 📝 `src/common/scm_rev.h` (+4 -0) 📝 `src/core/libraries/companion/companion_error.h` (+7 -0) ➕ `src/core/libraries/companion/companion_util.cpp` (+72 -0) ➕ `src/core/libraries/companion/companion_util.h` (+33 -0) 📝 `src/core/libraries/kernel/memory.cpp` (+72 -38) 📝 `src/core/libraries/kernel/memory.h` (+9 -9) 📝 `src/core/libraries/kernel/threads/pthread.cpp` (+27 -4) 📝 `src/core/libraries/kernel/threads/pthread_attr.cpp` (+2 -0) 📝 `src/core/libraries/libs.cpp` (+4 -0) 📝 `src/core/libraries/network/net.cpp` (+139 -7) 📝 `src/core/libraries/network/net.h` (+4 -0) 📝 `src/core/libraries/np_manager/np_manager.cpp` (+25 -11) 📝 `src/core/libraries/np_manager/np_manager.h` (+8 -1) _...and 32 more files_ </details> ### 📄 Description Needs more testing, I've tried with Ni no Kuni II but it makes no visible difference there. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>