[PR #2992] [CLOSED] video_out: SubmitEopFlip adding mutex and lockguard also fixing reject of full flips by adding a wait #3134

New issue

Closed

opened 2026-02-27 22:02:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2992
Author: @diegolix29
Created: 5/26/2025
Status: ❌ Closed

Base: main ← Head: Flip-bug-T

📝 Commits (7)

61ce2c4 video_out: using mutex and lockguard to prevent race conditions, updating buffer labels and adding buffer id for flip sumission error.
7bd134a adding pending mutex and flips
8a4eb9e wait for space on flip queue and ensuring the queue gets properly drained
8beb7a7 avoiding deadlocks
a5454c7 Fixing uncapped fps on debug state
528f7a2 Suggestions and removing peding mutex now
58362db clean up

📊 Changes

2 files changed (+14 additions, -10 deletions)

View changed files

📝 src/core/libraries/videoout/driver.cpp (+7 -5)
📝 src/core/libraries/videoout/video_out.cpp (+7 -5)

📄 Description

This stops the flip bug we have on video out on my end while testing dark souls 3 fire fades
updating buffer labels, and adding buffer id for logging on error
let me know if its ok.

Also fixed a discrepancy on driver.cpp

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2992 **Author:** [@diegolix29](https://github.com/diegolix29) **Created:** 5/26/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `Flip-bug-T` --- ### 📝 Commits (7) - [`61ce2c4`](https://github.com/shadps4-emu/shadPS4/commit/61ce2c4294d63f917095eb8643b07f9bb6c1ab14) video_out: using mutex and lockguard to prevent race conditions, updating buffer labels and adding buffer id for flip sumission error. - [`7bd134a`](https://github.com/shadps4-emu/shadPS4/commit/7bd134ae877d677e71a5ee0b79e4518fa8526938) adding pending mutex and flips - [`8a4eb9e`](https://github.com/shadps4-emu/shadPS4/commit/8a4eb9ef7aac9ae1b2793f295f2cd462dd5cf383) wait for space on flip queue and ensuring the queue gets properly drained - [`8beb7a7`](https://github.com/shadps4-emu/shadPS4/commit/8beb7a792a830ddee8b6dd548ab640a8a010440c) avoiding deadlocks - [`a5454c7`](https://github.com/shadps4-emu/shadPS4/commit/a5454c7fed0f3a9a98835c6823adf5f1cfb08587) Fixing uncapped fps on debug state - [`528f7a2`](https://github.com/shadps4-emu/shadPS4/commit/528f7a29f43a92f0f434c86a493247a1ae1ac7ed) Suggestions and removing peding mutex now - [`58362db`](https://github.com/shadps4-emu/shadPS4/commit/58362dba98e2175807108f8d63b459b8a52f94a7) clean up ### 📊 Changes **2 files changed** (+14 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/videoout/driver.cpp` (+7 -5) 📝 `src/core/libraries/videoout/video_out.cpp` (+7 -5) </details> ### 📄 Description This stops the flip bug we have on video out on my end while testing dark souls 3 fire fades updating buffer labels, and adding buffer id for logging on error let me know if its ok. Also fixed a discrepancy on driver.cpp --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>