[PR #2961] [MERGED] Fix image extent in buffer copy to image #3111

Closed
opened 2026-02-27 22:02:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2961
Author: @mikusp
Created: 5/20/2025
Status: Merged
Merged: 5/22/2025
Merged by: @squidbus

Base: mainHead: fix_copy_buffer_to_image_extent


📝 Commits (1)

  • 039ee99 Fix image extent in buffer copy to image

📊 Changes

1 file changed (+9 additions, -3 deletions)

View changed files

📝 src/video_core/texture_cache/texture_cache.cpp (+9 -3)

📄 Description

Fixes a Vulkan validation error hit by AKIBA'S BEAT [CUSA07108]:

[Render.Vulkan] <Error> vk_platform.cpp:56 DebugUtilsCallback: VUID-VkBufferImageCopy-bufferRowLength-09101: vkCmdCopyBufferToImage(): pRegions[0].bufferRowLength (1920) must be zero or greater-than-or-equal-to imageExtent.width (2048).
The Vulkan spec states: bufferRowLength must be 0, or greater than or equal to the width member of imageExtent (https://docs.vulkan.org/spec/latest/chapters/copies.html#VUID-VkBufferImageCopy-bufferRowLength-09101)

Previously it crashed after showing logos with a device lost error, now it shows the intro movies correctly and gets ingame.

Screenshot From 2025-05-20 18-01-00
Screenshot From 2025-05-20 18-01-16
Screenshot From 2025-05-20 18-01-36


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2961 **Author:** [@mikusp](https://github.com/mikusp) **Created:** 5/20/2025 **Status:** ✅ Merged **Merged:** 5/22/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `fix_copy_buffer_to_image_extent` --- ### 📝 Commits (1) - [`039ee99`](https://github.com/shadps4-emu/shadPS4/commit/039ee99b117a5b80bf3f74642e84d0602eeb5b03) Fix image extent in buffer copy to image ### 📊 Changes **1 file changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/texture_cache/texture_cache.cpp` (+9 -3) </details> ### 📄 Description Fixes a Vulkan validation error hit by AKIBA'S BEAT [CUSA07108]: ``` [Render.Vulkan] <Error> vk_platform.cpp:56 DebugUtilsCallback: VUID-VkBufferImageCopy-bufferRowLength-09101: vkCmdCopyBufferToImage(): pRegions[0].bufferRowLength (1920) must be zero or greater-than-or-equal-to imageExtent.width (2048). The Vulkan spec states: bufferRowLength must be 0, or greater than or equal to the width member of imageExtent (https://docs.vulkan.org/spec/latest/chapters/copies.html#VUID-VkBufferImageCopy-bufferRowLength-09101) ``` Previously it crashed after showing logos with a device lost error, now it shows the intro movies correctly and gets ingame. ![Screenshot From 2025-05-20 18-01-00](https://github.com/user-attachments/assets/9ad49e68-ec5e-4842-8304-81a6b65fa880) ![Screenshot From 2025-05-20 18-01-16](https://github.com/user-attachments/assets/3b931b95-7861-4937-a7d8-e1a7bd7c7cda) ![Screenshot From 2025-05-20 18-01-36](https://github.com/user-attachments/assets/f915a529-9448-4603-82b7-18971409e1b9) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:02:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#3111
No description provided.