[PR #2945] [MERGED] libkernel: Don't align fixed memory mappings #3104

Closed
opened 2026-02-27 22:02:27 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2945
Author: @StevenMiller123
Created: 5/16/2025
Status: Merged
Merged: 5/16/2025
Merged by: @squidbus

Base: mainHead: mem-fixes-again


📝 Commits (2)

  • b248ab1 Only align when flags Fixed is not present
  • 7f4e1e0 Merge branch 'shadps4-emu:main' into mem-fixes-again

📊 Changes

1 file changed (+5 additions, -6 deletions)

View changed files

📝 src/core/memory.cpp (+5 -6)

📄 Description

Based on hardware observations, when MemoryMapFlags::Fixed is specified, alignment values are ignored.

This should fix some remaining memory troubles, including problems seen in Horizon Zero Dawn™: Complete Edition (CUSA10213).

Pinging @gandalfthewhite19890404 for tests, since I don't own this title.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2945 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 5/16/2025 **Status:** ✅ Merged **Merged:** 5/16/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `mem-fixes-again` --- ### 📝 Commits (2) - [`b248ab1`](https://github.com/shadps4-emu/shadPS4/commit/b248ab13d6f4cba092f122a3ff4c231f9eadf9be) Only align when flags Fixed is not present - [`7f4e1e0`](https://github.com/shadps4-emu/shadPS4/commit/7f4e1e055315030c2f25602f3eaba69b9cbab0f2) Merge branch 'shadps4-emu:main' into mem-fixes-again ### 📊 Changes **1 file changed** (+5 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/core/memory.cpp` (+5 -6) </details> ### 📄 Description Based on hardware observations, when MemoryMapFlags::Fixed is specified, alignment values are ignored. This should fix some remaining memory troubles, including problems seen in Horizon Zero Dawn™: Complete Edition (CUSA10213). Pinging @gandalfthewhite19890404 for tests, since I don't own this title. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:02:27 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#3104
No description provided.