[PR #2928] [MERGED] Avoid post-increment of SGPR in S_*_LOAD_DWORD #3090

New issue

Closed

opened 2026-02-27 22:02:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2928
Author: @mikusp
Created: 5/13/2025
Status: ✅ Merged
Merged: 5/13/2025
Merged by: @squidbus

Base: main ← Head: s_load_dword_last_sgpr

📝 Commits (1)

6214342 Avoid post-increment of SGPR in S_*_LOAD_DWORD

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/shader_recompiler/frontend/translate/scalar_memory.cpp (+2 -2)

📄 Description

Hit by Killzone Shadow Fall - when translating an instruction like s_load_dwordx8 s[96:103], ..., the post-increment would hit an overflow error on the last iteration of the loop

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2928 **Author:** [@mikusp](https://github.com/mikusp) **Created:** 5/13/2025 **Status:** ✅ Merged **Merged:** 5/13/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `s_load_dword_last_sgpr` --- ### 📝 Commits (1) - [`6214342`](https://github.com/shadps4-emu/shadPS4/commit/6214342d58838d5e9c2f9b7eac6f43549470e98c) Avoid post-increment of SGPR in S_*_LOAD_DWORD ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/translate/scalar_memory.cpp` (+2 -2) </details> ### 📄 Description Hit by Killzone Shadow Fall - when translating an instruction like `s_load_dwordx8 s[96:103], ...`, the post-increment would hit an overflow error on the last iteration of the loop --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>