[PR #2859] [MERGED] vk_rasterizer: Fix updating wrong color attachment when skipped by mask. #3035

New issue

Closed

opened 2026-02-27 22:02:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2859
Author: @squidbus
Created: 4/28/2025
Status: ✅ Merged
Merged: 4/29/2025
Merged by: @squidbus

Base: main ← Head: fix-cb-skip

📝 Commits (1)

27ffbe8 vk_rasterizer: Fix updating wrong color attachment when skipped by mask.

📊 Changes

1 file changed (+9 additions, -5 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+9 -5)

📄 Description

Fix a bug where if a color attachment is skipped and bound to VK_NULL_HANDLE due to being masked out, the updates applied later based on cb_descs would not also skip those attachments and thus updates after the skipped index would be off.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2859 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 4/28/2025 **Status:** ✅ Merged **Merged:** 4/29/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `fix-cb-skip` --- ### 📝 Commits (1) - [`27ffbe8`](https://github.com/shadps4-emu/shadPS4/commit/27ffbe83943e517b287e483750951336a54bc014) vk_rasterizer: Fix updating wrong color attachment when skipped by mask. ### 📊 Changes **1 file changed** (+9 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+9 -5) </details> ### 📄 Description Fix a bug where if a color attachment is skipped and bound to `VK_NULL_HANDLE` due to being masked out, the updates applied later based on `cb_descs` would not also skip those attachments and thus updates after the skipped index would be off. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>