[PR #2837] [CLOSED] changin assert to fill tile size #3016

New issue

Closed

opened 2026-02-27 22:02:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2837
Author: @diegolix29
Created: 4/24/2025
Status: ❌ Closed

Base: main ← Head: filing-tiles

📝 Commits (9)

bbb095e removing assert ==1 by calculating and filling tile size
2954627 test 2
6b101cf now we handle all mip levels
5e926f0 clang
21dea2a Merge branch 'main' into filing-tiles
872cc17 suggestions
e27dcb1 more test
7cffa5b suggestion and fix rebase
c238d51 cleaning up old commits

📊 Changes

1 file changed (+34 additions, -11 deletions)

View changed files

📝 src/video_core/texture_cache/tile_manager.cpp (+34 -11)

📄 Description

removing assert for levels == 1 instead, now it calculates and fills tile size parameters needed for detiling.

Fixes broken graphics in DMC4 Special Edition

This is with assert as it was

This is with the assert commented out

And this is with this PR

havent tested with other games right now so it may be useful to test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2837 **Author:** [@diegolix29](https://github.com/diegolix29) **Created:** 4/24/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `filing-tiles` --- ### 📝 Commits (9) - [`bbb095e`](https://github.com/shadps4-emu/shadPS4/commit/bbb095e3219e426922ed14e3a4cd8469b9d6029e) removing assert ==1 by calculating and filling tile size - [`2954627`](https://github.com/shadps4-emu/shadPS4/commit/295462722f87f29ca61b992afaabf7947b2c7da5) test 2 - [`6b101cf`](https://github.com/shadps4-emu/shadPS4/commit/6b101cf55b090f22275442c75ef5c62107a7c52e) now we handle all mip levels - [`5e926f0`](https://github.com/shadps4-emu/shadPS4/commit/5e926f0423746f2137ae362186f50c14a53ea3e7) clang - [`21dea2a`](https://github.com/shadps4-emu/shadPS4/commit/21dea2abbcbf12baa1278207a17ddabfd97dc9d6) Merge branch 'main' into filing-tiles - [`872cc17`](https://github.com/shadps4-emu/shadPS4/commit/872cc1747ccf60e4c897327eb2b1289eccbf3a92) suggestions - [`e27dcb1`](https://github.com/shadps4-emu/shadPS4/commit/e27dcb1816788189963ad3c4c5baa562689026c9) more test - [`7cffa5b`](https://github.com/shadps4-emu/shadPS4/commit/7cffa5becf239d47a7f550193a74294e7056a03e) suggestion and fix rebase - [`c238d51`](https://github.com/shadps4-emu/shadPS4/commit/c238d5149863314377cab753b419a288cb37e964) cleaning up old commits ### 📊 Changes **1 file changed** (+34 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/texture_cache/tile_manager.cpp` (+34 -11) </details> ### 📄 Description removing assert for levels == 1 instead, now it calculates and fills tile size parameters needed for detiling. Fixes broken graphics in DMC4 Special Edition This is with assert as it was ![image](https://github.com/user-attachments/assets/22d4eadb-a509-4f08-a32e-e6cacff64c61) This is with the assert commented out ![image](https://github.com/user-attachments/assets/052d5a4a-00c2-4b86-a1d8-e4fa05a3af79) And this is with this PR ![image](https://github.com/user-attachments/assets/cd73f741-5ebf-4443-82c8-5d936f8ef98a) havent tested with other games right now so it may be useful to test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>