[PR #2830] [MERGED] texture_cache: Relax mismatched image type from assert to cache miss. #3014

New issue

Closed

opened 2026-02-27 22:02:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2830
Author: @squidbus
Created: 4/22/2025
Status: ✅ Merged
Merged: 4/22/2025
Merged by: @squidbus

Base: main ← Head: tcache

📝 Commits (1)

4dcfedc texture_cache: Relax mismatched image type from assert to cache miss.

📊 Changes

1 file changed (+2 additions, -5 deletions)

View changed files

📝 src/video_core/texture_cache/texture_cache.cpp (+2 -5)

📄 Description

Relaxes the image type check to a cache miss. In cases where a dimension is 1 or conditions are relaxed I think it should be a valid miss. Worst case we just have some games that were crashing before that are now just cache missing instead.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2830 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 4/22/2025 **Status:** ✅ Merged **Merged:** 4/22/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `tcache` --- ### 📝 Commits (1) - [`4dcfedc`](https://github.com/shadps4-emu/shadPS4/commit/4dcfedc82d286117a82bb981b248e68549067204) texture_cache: Relax mismatched image type from assert to cache miss. ### 📊 Changes **1 file changed** (+2 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/texture_cache/texture_cache.cpp` (+2 -5) </details> ### 📄 Description Relaxes the image type check to a cache miss. In cases where a dimension is 1 or conditions are relaxed I think it should be a valid miss. Worst case we just have some games that were crashing before that are now just cache missing instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>