[PR #2820] [MERGED] Implement IMAGE_ATOMIC_FMIN and IMAGE_ATOMIC_FMAX for 32bit floats #3005

New issue

Closed

opened 2026-02-27 22:02:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2820
Author: @mikusp
Created: 4/20/2025
Status: ✅ Merged
Merged: 4/30/2025
Merged by: @squidbus

Base: main ← Head: image_atomic_fmin_fmax

📝 Commits (2)

b327f4a Implement IMAGE_ATOMIC_FMIN and IMAGE_ATOMIC_FMAX for 32bit floats
03b1992 Handle missing VK_EXT_shader_atomic_float2

📊 Changes

16 files changed (+106 additions, -2 deletions)

View changed files

📝 externals/sirit (+1 -1)
📝 src/shader_recompiler/backend/spirv/emit_spirv.cpp (+4 -0)
📝 src/shader_recompiler/backend/spirv/emit_spirv_atomic.cpp (+42 -0)
📝 src/shader_recompiler/backend/spirv/emit_spirv_instructions.h (+2 -0)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+1 -0)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.h (+1 -0)
📝 src/shader_recompiler/frontend/translate/vector_memory.cpp (+8 -0)
📝 src/shader_recompiler/info.h (+1 -0)
📝 src/shader_recompiler/ir/ir_emitter.cpp (+10 -0)
📝 src/shader_recompiler/ir/ir_emitter.h (+4 -0)
📝 src/shader_recompiler/ir/opcodes.inc (+2 -0)
📝 src/shader_recompiler/ir/passes/shader_info_collection_pass.cpp (+4 -0)
📝 src/shader_recompiler/profile.h (+1 -0)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+16 -1)
📝 src/video_core/renderer_vulkan/vk_instance.h (+8 -0)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+1 -0)

📄 Description

I've tried to do what other atomic image operations do, let me know if there is anything that needs to be changed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2820 **Author:** [@mikusp](https://github.com/mikusp) **Created:** 4/20/2025 **Status:** ✅ Merged **Merged:** 4/30/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `image_atomic_fmin_fmax` --- ### 📝 Commits (2) - [`b327f4a`](https://github.com/shadps4-emu/shadPS4/commit/b327f4a4bc3ec31752e1d42467f351eec246cb0e) Implement IMAGE_ATOMIC_FMIN and IMAGE_ATOMIC_FMAX for 32bit floats - [`03b1992`](https://github.com/shadps4-emu/shadPS4/commit/03b19926ae9c8403aa6c6c0ce9711425afec5ecb) Handle missing VK_EXT_shader_atomic_float2 ### 📊 Changes **16 files changed** (+106 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `externals/sirit` (+1 -1) 📝 `src/shader_recompiler/backend/spirv/emit_spirv.cpp` (+4 -0) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_atomic.cpp` (+42 -0) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_instructions.h` (+2 -0) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+1 -0) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.h` (+1 -0) 📝 `src/shader_recompiler/frontend/translate/vector_memory.cpp` (+8 -0) 📝 `src/shader_recompiler/info.h` (+1 -0) 📝 `src/shader_recompiler/ir/ir_emitter.cpp` (+10 -0) 📝 `src/shader_recompiler/ir/ir_emitter.h` (+4 -0) 📝 `src/shader_recompiler/ir/opcodes.inc` (+2 -0) 📝 `src/shader_recompiler/ir/passes/shader_info_collection_pass.cpp` (+4 -0) 📝 `src/shader_recompiler/profile.h` (+1 -0) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+16 -1) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+8 -0) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+1 -0) </details> ### 📄 Description I've tried to do what other atomic image operations do, let me know if there is anything that needs to be changed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>