[PR #2818] [CLOSED] Skip PromoteFormatToDepth in the case of a dummy image #3004

New issue

Closed

opened 2026-02-27 22:02:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2818
Author: @kalaposfos13
Created: 4/20/2025
Status: ❌ Closed

Base: main ← Head: dont-promote-format-to-depth

📝 Commits (6)

7fa2d0e Skip PromoteFormatToDepth in the case of a dummy image
1f1f8d1 Use a cleaner error check
a3bae94 Set format to eD32Sfloat for the dummy 1x1 images
29a0e0c Change the control flow to be a bit more readable
161cb46 Readd accidentally reverted change
774c3be Add dummy depth image

📊 Changes

4 files changed (+71 additions, -29 deletions)

View changed files

📝 src/video_core/amdgpu/resource.h (+13 -0)
📝 src/video_core/renderer_vulkan/liverpool_to_vk.h (+1 -1)
📝 src/video_core/texture_cache/image_info.cpp (+33 -19)
📝 src/video_core/texture_cache/image_view.cpp (+24 -9)

📄 Description

Attempts to solve some cases of the PromoteFormatToDepth unreachable, by not calling the function if the image is a dummy 1x1 image, and in those cases, the format is also set to be eD32Sfloat, so it is a valid depth image.
Also adds more debug info in case of a failure

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2818 **Author:** [@kalaposfos13](https://github.com/kalaposfos13) **Created:** 4/20/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dont-promote-format-to-depth` --- ### 📝 Commits (6) - [`7fa2d0e`](https://github.com/shadps4-emu/shadPS4/commit/7fa2d0ea42ffec01006d8b6cfaf9451ff607538f) Skip PromoteFormatToDepth in the case of a dummy image - [`1f1f8d1`](https://github.com/shadps4-emu/shadPS4/commit/1f1f8d1037cc4aaa0fe09512e5846aa1f0836599) Use a cleaner error check - [`a3bae94`](https://github.com/shadps4-emu/shadPS4/commit/a3bae94f1eb1a67e62379f4417cb97bfa23889e4) Set format to eD32Sfloat for the dummy 1x1 images - [`29a0e0c`](https://github.com/shadps4-emu/shadPS4/commit/29a0e0c5b0670c194ed139047881691113399c2c) Change the control flow to be a bit more readable - [`161cb46`](https://github.com/shadps4-emu/shadPS4/commit/161cb46c4e314dfde1a4eaa8e107e3071bd09ed9) Readd accidentally reverted change - [`774c3be`](https://github.com/shadps4-emu/shadPS4/commit/774c3bec3025d2d7b29e4d74a4ec31b00928f4fc) Add dummy depth image ### 📊 Changes **4 files changed** (+71 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/amdgpu/resource.h` (+13 -0) 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.h` (+1 -1) 📝 `src/video_core/texture_cache/image_info.cpp` (+33 -19) 📝 `src/video_core/texture_cache/image_view.cpp` (+24 -9) </details> ### 📄 Description Attempts to solve some cases of the `PromoteFormatToDepth` unreachable, by not calling the function if the image is a dummy 1x1 image, and in those cases, the format is also set to be eD32Sfloat, so it is a valid depth image. Also adds more debug info in case of a failure --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>