[PR #2752] [MERGED] build: Move versioning to CMake file. #2954

New issue

Closed

opened 2026-02-27 22:01:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2752
Author: @squidbus
Created: 4/6/2025
Status: ✅ Merged
Merged: 4/7/2025
Merged by: @georgemoralis

Base: main ← Head: versioning

📝 Commits (1)

a0bbae6 build: Move versioning to CMake file.

📊 Changes

12 files changed (+37 additions, -56 deletions)

View changed files

📝 CMakeLists.txt (+4 -3)
📝 src/common/config.cpp (+5 -5)
📝 src/common/scm_rev.cpp.in (+9 -13)
📝 src/common/scm_rev.h (+3 -0)
➖ src/common/version.h (+0 -14)
📝 src/emulator.cpp (+5 -6)
📝 src/input/input_handler.cpp (+0 -1)
📝 src/qt_gui/check_update.cpp (+2 -3)
📝 src/qt_gui/gui_context_menus.h (+3 -3)
📝 src/qt_gui/main_window.cpp (+4 -5)
📝 src/qt_gui/settings_dialog.cpp (+2 -2)
📝 src/sdl_window.cpp (+0 -1)

📄 Description

Moves the version and release variables to the main CMake file, configured into the generated scm_rev.cpp for source access. This allows properly versioning the macOS release bundle without maintaining two different version strings.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2752 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 4/6/2025 **Status:** ✅ Merged **Merged:** 4/7/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `versioning` --- ### 📝 Commits (1) - [`a0bbae6`](https://github.com/shadps4-emu/shadPS4/commit/a0bbae65f901db431fae423c25ce5763e70d84c0) build: Move versioning to CMake file. ### 📊 Changes **12 files changed** (+37 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+4 -3) 📝 `src/common/config.cpp` (+5 -5) 📝 `src/common/scm_rev.cpp.in` (+9 -13) 📝 `src/common/scm_rev.h` (+3 -0) ➖ `src/common/version.h` (+0 -14) 📝 `src/emulator.cpp` (+5 -6) 📝 `src/input/input_handler.cpp` (+0 -1) 📝 `src/qt_gui/check_update.cpp` (+2 -3) 📝 `src/qt_gui/gui_context_menus.h` (+3 -3) 📝 `src/qt_gui/main_window.cpp` (+4 -5) 📝 `src/qt_gui/settings_dialog.cpp` (+2 -2) 📝 `src/sdl_window.cpp` (+0 -1) </details> ### 📄 Description Moves the version and release variables to the main CMake file, configured into the generated `scm_rev.cpp` for source access. This allows properly versioning the macOS release bundle without maintaining two different version strings. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>