[PR #2737] [MERGED] Only log fd warning if there's a file getting closed #2944

Closed
opened 2026-02-27 22:01:51 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2737
Author: @StevenMiller123
Created: 4/1/2025
Status: Merged
Merged: 4/1/2025
Merged by: @squidbus

Base: mainHead: log-hotfix


📝 Commits (1)

  • 96e4255 Only log fd warning if there's a file getting closed

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 src/core/libraries/kernel/file_system.cpp (+4 -4)

📄 Description

Minor nitpick from my FS cleanup PR, this was logging when games throw error codes into the fd param, when it shouldn't.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2737 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 4/1/2025 **Status:** ✅ Merged **Merged:** 4/1/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `log-hotfix` --- ### 📝 Commits (1) - [`96e4255`](https://github.com/shadps4-emu/shadPS4/commit/96e42554f22593368b4b2f105590b0ff7ed6079a) Only log fd warning if there's a file getting closed ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/kernel/file_system.cpp` (+4 -4) </details> ### 📄 Description Minor nitpick from my FS cleanup PR, this was logging when games throw error codes into the fd param, when it shouldn't. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:01:51 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2944
No description provided.