[PR #2732] [MERGED] Fix libSceNgs2 HLE regressions #2943

New issue

Closed

opened 2026-02-27 22:01:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2732
Author: @StevenMiller123
Created: 3/31/2025
Status: ✅ Merged
Merged: 4/1/2025
Merged by: @georgemoralis

Base: main ← Head: ngs2-hle-fixes

📝 Commits (8)

963f717 Fix sceNgs2SystemCreateWithAllocator
9f6335c Remove error handling for unimplemented functions
519159c Use Core::ExecuteGuest to execute allocator alloc and free
417dfcb Clang
6138484 Fix function definitions in ngs2.h
a7d1938 Fix function defs in ngs2_impl.h
811e62a Clang
b4bfabe Clang

📊 Changes

4 files changed (+60 additions, -118 deletions)

View changed files

📝 src/core/libraries/ngs2/ngs2.cpp (+44 -108)
📝 src/core/libraries/ngs2/ngs2.h (+11 -7)
📝 src/core/libraries/ngs2/ngs2_impl.h (+3 -2)
📝 src/core/libraries/ngs2/ngs2_report.h (+2 -1)

📄 Description

This PR attempts to resolve some of the libSceNgs2 HLE-related regressions showing up after https://github.com/shadps4-emu/shadPS4/pull/1604 was merged.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2732 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 3/31/2025 **Status:** ✅ Merged **Merged:** 4/1/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `ngs2-hle-fixes` --- ### 📝 Commits (8) - [`963f717`](https://github.com/shadps4-emu/shadPS4/commit/963f717b9d19f3611ce4df5ffe91f7240d0ac309) Fix sceNgs2SystemCreateWithAllocator - [`9f6335c`](https://github.com/shadps4-emu/shadPS4/commit/9f6335cba0fa8ba2ac869b94f95748e522d587e0) Remove error handling for unimplemented functions - [`519159c`](https://github.com/shadps4-emu/shadPS4/commit/519159c2199d0051c7f671bd55d441bc2ebc082c) Use Core::ExecuteGuest to execute allocator alloc and free - [`417dfcb`](https://github.com/shadps4-emu/shadPS4/commit/417dfcb02c9cd8cad9823241ee6f92ce7f3c018e) Clang - [`6138484`](https://github.com/shadps4-emu/shadPS4/commit/6138484479c706e3d1490c11724123c4977207ee) Fix function definitions in ngs2.h - [`a7d1938`](https://github.com/shadps4-emu/shadPS4/commit/a7d19381a1f73936794186bccae39c4f587c828a) Fix function defs in ngs2_impl.h - [`811e62a`](https://github.com/shadps4-emu/shadPS4/commit/811e62a048a981db8526c955a217888a4a866971) Clang - [`b4bfabe`](https://github.com/shadps4-emu/shadPS4/commit/b4bfabe29e3a29ae19b75b1655a7680c580a113d) Clang ### 📊 Changes **4 files changed** (+60 additions, -118 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/ngs2/ngs2.cpp` (+44 -108) 📝 `src/core/libraries/ngs2/ngs2.h` (+11 -7) 📝 `src/core/libraries/ngs2/ngs2_impl.h` (+3 -2) 📝 `src/core/libraries/ngs2/ngs2_report.h` (+2 -1) </details> ### 📄 Description This PR attempts to resolve some of the libSceNgs2 HLE-related regressions showing up after https://github.com/shadps4-emu/shadPS4/pull/1604 was merged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>