[PR #2714] [CLOSED] Replacing const with constexpr #2930

Closed
opened 2026-02-27 22:01:48 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2714
Author: @Xphalnos
Created: 3/29/2025
Status: Closed

Base: mainHead: main


📝 Commits (1)

  • 995afa0 Replacing const with constexpr

📊 Changes

35 files changed (+89 additions, -89 deletions)

View changed files

📝 src/common/decoder.cpp (+1 -1)
📝 src/common/logging/backend.cpp (+1 -1)
📝 src/common/number_utils.cpp (+2 -2)
📝 src/common/thread.cpp (+1 -1)
📝 src/common/types.h (+3 -3)
📝 src/core/cpu_patches.cpp (+12 -12)
📝 src/core/devtools/widget/imgui_memory_editor.h (+1 -1)
📝 src/core/devtools/widget/text_editor.cpp (+3 -3)
📝 src/core/libraries/audio3d/audio3d.h (+14 -14)
📝 src/core/libraries/libc_internal/printf.h (+3 -3)
📝 src/core/libraries/ngs2/ngs2.h (+3 -3)
📝 src/core/libraries/ngs2/ngs2_custom.h (+3 -3)
📝 src/core/libraries/ngs2/ngs2_impl.h (+2 -2)
📝 src/core/loader/elf.h (+1 -1)
📝 src/core/memory.cpp (+1 -1)
📝 src/imgui/renderer/imgui_impl_sdl3.cpp (+1 -1)
📝 src/input/controller.cpp (+2 -2)
📝 src/input/input_handler.h (+1 -1)
📝 src/main.cpp (+1 -1)
📝 src/qt_gui/game_info.cpp (+1 -1)

...and 15 more files

📄 Description

Use constexpr because it's more optimized since the value is set at compile time and not at startup.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2714 **Author:** [@Xphalnos](https://github.com/Xphalnos) **Created:** 3/29/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`995afa0`](https://github.com/shadps4-emu/shadPS4/commit/995afa045e12e134e3445d716a328b313317f824) Replacing const with constexpr ### 📊 Changes **35 files changed** (+89 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `src/common/decoder.cpp` (+1 -1) 📝 `src/common/logging/backend.cpp` (+1 -1) 📝 `src/common/number_utils.cpp` (+2 -2) 📝 `src/common/thread.cpp` (+1 -1) 📝 `src/common/types.h` (+3 -3) 📝 `src/core/cpu_patches.cpp` (+12 -12) 📝 `src/core/devtools/widget/imgui_memory_editor.h` (+1 -1) 📝 `src/core/devtools/widget/text_editor.cpp` (+3 -3) 📝 `src/core/libraries/audio3d/audio3d.h` (+14 -14) 📝 `src/core/libraries/libc_internal/printf.h` (+3 -3) 📝 `src/core/libraries/ngs2/ngs2.h` (+3 -3) 📝 `src/core/libraries/ngs2/ngs2_custom.h` (+3 -3) 📝 `src/core/libraries/ngs2/ngs2_impl.h` (+2 -2) 📝 `src/core/loader/elf.h` (+1 -1) 📝 `src/core/memory.cpp` (+1 -1) 📝 `src/imgui/renderer/imgui_impl_sdl3.cpp` (+1 -1) 📝 `src/input/controller.cpp` (+2 -2) 📝 `src/input/input_handler.h` (+1 -1) 📝 `src/main.cpp` (+1 -1) 📝 `src/qt_gui/game_info.cpp` (+1 -1) _...and 15 more files_ </details> ### 📄 Description Use constexpr because it's more optimized since the value is set at compile time and not at startup. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:01:48 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2930
No description provided.