[PR #2707] [MERGED] externals: Remove need for cryptopp build. #2926

New issue

Closed

opened 2026-02-27 22:01:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2707
Author: @squidbus
Created: 3/28/2025
Status: ✅ Merged
Merged: 3/29/2025
Merged by: @georgemoralis

Base: main ← Head: crypto

📝 Commits (1)

e79e402 externals: Remove need for cryptopp build.

📊 Changes

9 files changed (+1399 additions, -56 deletions)

View changed files

📝 .gitmodules (+0 -8)
📝 CMakeLists.txt (+3 -1)
📝 externals/CMakeLists.txt (+1 -15)
➖ externals/cryptopp (+0 -1)
➖ externals/cryptopp-cmake (+0 -1)
➕ src/common/aes.h (+1195 -0)
➕ src/common/sha1.h (+180 -0)
📝 src/core/file_format/trp.cpp (+14 -25)
📝 src/core/module.cpp (+6 -5)

📄 Description

Currently cryptopp is only used for:

SHA1 for NID calculation.
AES CBC for trophy decryption.

Since the uses are so small and simple, this PR replaces cryptopp with small single-header libraries for each case, eliminating a large sub-module dependency from the build which both hasn't been maintained in a while and has caused problems in the past.

Tested by:

Verifying that NIDs for some known function names calculate correctly.
Using the trophy viewer with a clean game data cache.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2707 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 3/28/2025 **Status:** ✅ Merged **Merged:** 3/29/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `crypto` --- ### 📝 Commits (1) - [`e79e402`](https://github.com/shadps4-emu/shadPS4/commit/e79e402d17f7d11063853c947affc40ffb00da28) externals: Remove need for cryptopp build. ### 📊 Changes **9 files changed** (+1399 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `.gitmodules` (+0 -8) 📝 `CMakeLists.txt` (+3 -1) 📝 `externals/CMakeLists.txt` (+1 -15) ➖ `externals/cryptopp` (+0 -1) ➖ `externals/cryptopp-cmake` (+0 -1) ➕ `src/common/aes.h` (+1195 -0) ➕ `src/common/sha1.h` (+180 -0) 📝 `src/core/file_format/trp.cpp` (+14 -25) 📝 `src/core/module.cpp` (+6 -5) </details> ### 📄 Description Currently cryptopp is only used for: * SHA1 for NID calculation. * AES CBC for trophy decryption. Since the uses are so small and simple, this PR replaces cryptopp with small single-header libraries for each case, eliminating a large sub-module dependency from the build which both hasn't been maintained in a while and has caused problems in the past. Tested by: * Verifying that NIDs for some known function names calculate correctly. * Using the trophy viewer with a clean game data cache. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>