[PR #2699] [MERGED] Fix support for unicode paths for game install directories #2921

New issue

Closed

opened 2026-02-27 22:01:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2699
Author: @k3dr1
Created: 3/28/2025
Status: ✅ Merged
Merged: 3/28/2025
Merged by: @georgemoralis

Base: main ← Head: main

📝 Commits (9)

f1b8dff Slightly changed how allInstallDirsDisabled is determined
5c53beb Merge branch 'main' of github.com:k3dr1/shadPS4
d2aa912 Show a dialog only if no game directories are set
6856323 Changed a comment
55f6bab Fixed formatting
118da16 Support for unicode paths for game install directories
0d87505 Merge branch 'shadps4-emu:main' into main
3c7c324 Fixed game picture path conversion
310c805 Merge branch 'main' of github.com:k3dr1/shadPS4

📊 Changes

3 files changed (+4 additions, -3 deletions)

View changed files

📝 src/common/config.cpp (+1 -1)
📝 src/qt_gui/game_list_frame.cpp (+2 -1)
📝 src/qt_gui/settings_dialog.cpp (+1 -1)

📄 Description

Addressing Issue 2378, namely not supporting unicode characters in the path to game install folders. Toml already stores them correctly, so by just changing the toml::find_or<> template to std::u8string we can read them correctly (relevant https://github.com/ToruNiina/toml11/issues/104). This is fine because the install paths get turned into std::filesystem::path anyway.

Before:

After:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2699 **Author:** [@k3dr1](https://github.com/k3dr1) **Created:** 3/28/2025 **Status:** ✅ Merged **Merged:** 3/28/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (9) - [`f1b8dff`](https://github.com/shadps4-emu/shadPS4/commit/f1b8dff87f2c4a3c6d991e8442652e18ca8e3266) Slightly changed how allInstallDirsDisabled is determined - [`5c53beb`](https://github.com/shadps4-emu/shadPS4/commit/5c53beb6a03f7641ebe86c6828d6bf095ab123a1) Merge branch 'main' of github.com:k3dr1/shadPS4 - [`d2aa912`](https://github.com/shadps4-emu/shadPS4/commit/d2aa912c371216495055fc5b39b6bc6244c13480) Show a dialog only if no game directories are set - [`6856323`](https://github.com/shadps4-emu/shadPS4/commit/68563239e478f38ed102345e8a5ebaaea3604f28) Changed a comment - [`55f6bab`](https://github.com/shadps4-emu/shadPS4/commit/55f6bab743097bdc0eee8d8b0c831e7fb34d376b) Fixed formatting - [`118da16`](https://github.com/shadps4-emu/shadPS4/commit/118da1670c9c412dfd9431ec0b3fc8e0ac19b501) Support for unicode paths for game install directories - [`0d87505`](https://github.com/shadps4-emu/shadPS4/commit/0d87505020833b070f03eb350ad8951c6e335dda) Merge branch 'shadps4-emu:main' into main - [`3c7c324`](https://github.com/shadps4-emu/shadPS4/commit/3c7c324afee44af263a8988491150c4d6346a5b9) Fixed game picture path conversion - [`310c805`](https://github.com/shadps4-emu/shadPS4/commit/310c8058c9e31ba86f53aba53cc49001f4f8ea89) Merge branch 'main' of github.com:k3dr1/shadPS4 ### 📊 Changes **3 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+1 -1) 📝 `src/qt_gui/game_list_frame.cpp` (+2 -1) 📝 `src/qt_gui/settings_dialog.cpp` (+1 -1) </details> ### 📄 Description Addressing [Issue 2378](https://github.com/shadps4-emu/shadPS4/issues/2378), namely not supporting unicode characters in the path to game install folders. Toml already stores them correctly, so by just changing the toml::find_or<> template to std::u8string we can read them correctly (relevant https://github.com/ToruNiina/toml11/issues/104). This is fine because the install paths get turned into std::filesystem::path anyway. Before: ![shadps4_pSlEPKPCh6](https://github.com/user-attachments/assets/68f35f0a-2973-4020-ba9b-7437adf49dcd) After: ![shadps4_3ueD4t3aTE](https://github.com/user-attachments/assets/f2d5ae0d-ff6c-4dc1-a646-6f807582c071) ![shadps4_N9IpHw6TrE](https://github.com/user-attachments/assets/ed7f131e-06d9-4d1a-9668-f005acb02fd2) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>