[PR #2686] [MERGED] HLE discmap #2907

New issue

Closed

opened 2026-02-27 22:01:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2686
Author: @georgemoralis
Created: 3/25/2025
Status: ✅ Merged
Merged: 3/25/2025
Merged by: @georgemoralis

Base: main ← Head: discmap

📝 Commits (3)

07fdfce HLE discmap
27ae27d improved parameters naming
27aa9b4 fixed typo

📊 Changes

4 files changed (+19 additions, -17 deletions)

View changed files

📝 src/core/libraries/disc_map/disc_map.cpp (+11 -11)
📝 src/core/libraries/disc_map/disc_map.h (+6 -4)
📝 src/core/libraries/libs.cpp (+1 -0)
📝 src/emulator.cpp (+1 -2)

📄 Description

This eliminates the need for discmap , based on @red-prig suggestions

According to RE on ghidra all calls seems to check if lib is init first using a global

if (DAT_010080e0 == 0) { uVar2 = ORBIS_DISC_MAP_ERROR_NO_BITMAP_INFO; }

so it is rather safe to return this , since it is likely the same we do when we load this lib lle

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2686 **Author:** [@georgemoralis](https://github.com/georgemoralis) **Created:** 3/25/2025 **Status:** ✅ Merged **Merged:** 3/25/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `discmap` --- ### 📝 Commits (3) - [`07fdfce`](https://github.com/shadps4-emu/shadPS4/commit/07fdfceff564677af66e95963dcbaf2e0b69904a) HLE discmap - [`27ae27d`](https://github.com/shadps4-emu/shadPS4/commit/27ae27dc8be0aa4ef3361e57347d95b241933174) improved parameters naming - [`27aa9b4`](https://github.com/shadps4-emu/shadPS4/commit/27aa9b4a46f78e601207efddc12a0a1432c4c490) fixed typo ### 📊 Changes **4 files changed** (+19 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/disc_map/disc_map.cpp` (+11 -11) 📝 `src/core/libraries/disc_map/disc_map.h` (+6 -4) 📝 `src/core/libraries/libs.cpp` (+1 -0) 📝 `src/emulator.cpp` (+1 -2) </details> ### 📄 Description This eliminates the need for discmap , based on @red-prig suggestions According to RE on ghidra all calls seems to check if lib is init first using a global ` if (DAT_010080e0 == 0) { uVar2 = ORBIS_DISC_MAP_ERROR_NO_BITMAP_INFO; }` so it is rather safe to return this , since it is likely the same we do when we load this lib lle --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>