[PR #2676] [MERGED] QT: Fix PR 2662 - checkbox/Choose directory #2903

Closed
opened 2026-02-27 22:01:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2676
Author: @DanielSvoboda
Created: 3/23/2025
Status: Merged
Merged: 3/23/2025
Merged by: @georgemoralis

Base: mainHead: main


📝 Commits (1)

📊 Changes

4 files changed (+11 additions, -6 deletions)

View changed files

📝 src/common/config.cpp (+3 -3)
📝 src/common/config.h (+1 -1)
📝 src/qt_gui/main.cpp (+6 -1)
📝 src/qt_gui/settings_dialog.cpp (+1 -1)

📄 Description

After PR 2662 added a checkbox to the list of game folders, if they were all disabled, when opening the emulator the screen to add a new folder appeared, as if none had been added.
This PR fixes this. That screen will only appear if there are no folders added.

*getAllGameInstallDirs was removed as it was not used.

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2676 **Author:** [@DanielSvoboda](https://github.com/DanielSvoboda) **Created:** 3/23/2025 **Status:** ✅ Merged **Merged:** 3/23/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`83ef7d2`](https://github.com/shadps4-emu/shadPS4/commit/83ef7d2b64f8c426414b0a160f7b7b7296722d6d) QT: Fix PR 2662 ### 📊 Changes **4 files changed** (+11 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+3 -3) 📝 `src/common/config.h` (+1 -1) 📝 `src/qt_gui/main.cpp` (+6 -1) 📝 `src/qt_gui/settings_dialog.cpp` (+1 -1) </details> ### 📄 Description After [PR 2662](https://github.com/shadps4-emu/shadPS4/pull/2662) added a checkbox to the list of game folders, if they were all disabled, when opening the emulator the screen to add a new folder appeared, as if none had been added. This PR fixes this. That screen will only appear if there are no folders added. *getAllGameInstallDirs was removed as it was not used. ![image](https://github.com/user-attachments/assets/aa167728-8a26-4f8b-a984-2516adacd31f) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:01:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2903
No description provided.