[PR #2642] [MERGED] Properly implement sceVideoOutGetBufferLabelAddress #2881

New issue

Closed

opened 2026-02-27 22:01:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2642
Author: @StevenMiller123
Created: 3/11/2025
Status: ✅ Merged
Merged: 3/12/2025
Merged by: @georgemoralis

Base: main ← Head: videoout-fixes

📝 Commits (3)

f9de7ac Export sceVideoOutGetBufferLabelAddress
06994fa More sceVideoOutGetBufferLabelAddress fixups
67d9218 Final fixups

📊 Changes

3 files changed (+17 additions, -5 deletions)

View changed files

📝 src/core/libraries/gnmdriver/gnmdriver.cpp (+4 -2)
📝 src/core/libraries/videoout/video_out.cpp (+12 -2)
📝 src/core/libraries/videoout/video_out.h (+1 -1)

📄 Description

red_prig made an OpenOrbis homebrew sample that uses this function, and since we weren't exporting it, some checks the sample performs were failing.

This PR makes the necessary changes to sceVideoOutGetBufferLabelAddress to make its behavior align with expected library behaviors, and adds exports so games and homebrew samples can properly call this function.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2642 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 3/11/2025 **Status:** ✅ Merged **Merged:** 3/12/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `videoout-fixes` --- ### 📝 Commits (3) - [`f9de7ac`](https://github.com/shadps4-emu/shadPS4/commit/f9de7acee634603df3dbc3db44fac798d924d3eb) Export sceVideoOutGetBufferLabelAddress - [`06994fa`](https://github.com/shadps4-emu/shadPS4/commit/06994fa70506c32cd2f4af5fcdbfec0f0122e69e) More sceVideoOutGetBufferLabelAddress fixups - [`67d9218`](https://github.com/shadps4-emu/shadPS4/commit/67d9218101f8f6e3d644dc8d61a2bdc9442abd31) Final fixups ### 📊 Changes **3 files changed** (+17 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/gnmdriver/gnmdriver.cpp` (+4 -2) 📝 `src/core/libraries/videoout/video_out.cpp` (+12 -2) 📝 `src/core/libraries/videoout/video_out.h` (+1 -1) </details> ### 📄 Description red_prig made an OpenOrbis homebrew sample that uses this function, and since we weren't exporting it, some checks the sample performs were failing. This PR makes the necessary changes to sceVideoOutGetBufferLabelAddress to make its behavior align with expected library behaviors, and adds exports so games and homebrew samples can properly call this function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>