mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-25 07:46:01 +03:00
[PR #2629] [MERGED] Handle error behavior in sceSysmoduleGetModuleInfoForUnwind stub #2872
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#2872
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/2629
Author: @StevenMiller123
Created: 3/8/2025
Status: ✅ Merged
Merged: 3/9/2025
Merged by: @georgemoralis
Base:
main← Head:unwind-stuff📝 Commits (3)
3251433Stubby implementation of sceSysmoduleGetModuleInfoForUnwindca4380eUpdate sysmodule.cppb0e3297Minor cleanup📊 Changes
4 files changed (+23 additions, -16 deletions)
View changed files
📝
src/core/libraries/kernel/process.cpp(+1 -13)📝
src/core/libraries/kernel/process.h(+15 -0)📝
src/core/libraries/system/sysmodule.cpp(+6 -2)📝
src/core/libraries/system/sysmodule.h(+1 -1)📄 Description
This PR partially implements
sceSysmoduleGetModuleInfoForUnwindby callingsceKernelGetModuleInfoForUnwindand returning any errors that throws. I've avoided handling whatever internal struct libSceSysmodule uses here, since the struct seems to be somewhat different from the kernel's module info struct based on what I've decompiled, and the old return 0 behavior was working fine enough before.Allowing this function to pass along errors fixes libc spamming
sceKernelGetModuleInfoForUnwindcalls with invalid addresses, fixing random crashes in Unity games caused by libc accessing invalid memory during exceptions.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.