[PR #2598] [MERGED] Adds missing tr functions for certain GUI strings that should be translatable #2850

Closed
opened 2026-02-27 22:01:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2598
Author: @rainmakerv3
Created: 3/5/2025
Status: Merged
Merged: 3/6/2025
Merged by: @georgemoralis

Base: mainHead: TRs


📝 Commits (2)

  • 1785503 Adds missing tr functions for certain GUI strings that should be translatable
  • a1a1a45 set clang format off for multi-line strings, set userDir as arg

📊 Changes

5 files changed (+55 additions, -54 deletions)

View changed files

📝 src/qt_gui/control_settings.cpp (+2 -2)
📝 src/qt_gui/kbm_config_dialog.cpp (+11 -11)
📝 src/qt_gui/kbm_gui.cpp (+21 -20)
📝 src/qt_gui/kbm_help_dialog.cpp (+6 -6)
📝 src/qt_gui/settings_dialog.cpp (+15 -15)

📄 Description

Some GUI strings which are user-facing currently do not have tr functions, so they cannot be translated. There are some more other than this which are more difficult to do (some requiring maps, and some like the special keybinding section which are difficult to handle), but at least this quick PR covers the easy ones.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2598 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 3/5/2025 **Status:** ✅ Merged **Merged:** 3/6/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `TRs` --- ### 📝 Commits (2) - [`1785503`](https://github.com/shadps4-emu/shadPS4/commit/17855035430272a2160ce9cbb9ea81519cb1754e) Adds missing tr functions for certain GUI strings that should be translatable - [`a1a1a45`](https://github.com/shadps4-emu/shadPS4/commit/a1a1a45fe3ad4eaeb54b3cea8b5db940b8931846) set clang format off for multi-line strings, set userDir as arg ### 📊 Changes **5 files changed** (+55 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/control_settings.cpp` (+2 -2) 📝 `src/qt_gui/kbm_config_dialog.cpp` (+11 -11) 📝 `src/qt_gui/kbm_gui.cpp` (+21 -20) 📝 `src/qt_gui/kbm_help_dialog.cpp` (+6 -6) 📝 `src/qt_gui/settings_dialog.cpp` (+15 -15) </details> ### 📄 Description Some GUI strings which are user-facing currently do not have tr functions, so they cannot be translated. There are some more other than this which are more difficult to do (some requiring maps, and some like the special keybinding section which are difficult to handle), but at least this quick PR covers the easy ones. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:01:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2850
No description provided.