[PR #2583] [MERGED] Add support for primitive type AdjLineList #2838

Closed
opened 2026-02-27 22:01:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2583
Author: @Missake212
Created: 3/2/2025
Status: Merged
Merged: 3/2/2025
Merged by: @raphaelthegreat

Base: mainHead: nier-fixes


📝 Commits (2)

  • 59acb8e fixes to get in game
  • f428ee2 Merge branch 'shadps4-emu:main' into nier-fixes

📊 Changes

2 files changed (+4 additions, -0 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv.cpp (+2 -0)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+2 -0)

📄 Description

Add support for primitive type AdjLineList that allows NieR Replicant™ ver.1.22474487139... to go in game, all credits goes to Turtle, they're the one who figured it out I'm just opening the PR. Not sure if that could fix other games that were previously hitting either of these two errors, feel free to try.

[Debug] <Critical> spirv_emit_context.cpp:54 NumVertices: Unreachable code!

[Debug] <Critical> emit_spirv.cpp:GetInputPrimitiveType:36: Unreachable code! Unknown input primitive type 10


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2583 **Author:** [@Missake212](https://github.com/Missake212) **Created:** 3/2/2025 **Status:** ✅ Merged **Merged:** 3/2/2025 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `nier-fixes` --- ### 📝 Commits (2) - [`59acb8e`](https://github.com/shadps4-emu/shadPS4/commit/59acb8e2616218e5d111d12f3afe97e333ba43ab) fixes to get in game - [`f428ee2`](https://github.com/shadps4-emu/shadPS4/commit/f428ee2b8d3a4f66e350a647a818c35a306daa93) Merge branch 'shadps4-emu:main' into nier-fixes ### 📊 Changes **2 files changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv.cpp` (+2 -0) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+2 -0) </details> ### 📄 Description Add support for primitive type AdjLineList that allows NieR Replicant™ ver.1.22474487139... to go in game, all credits goes to Turtle, they're the one who figured it out I'm just opening the PR. Not sure if that could fix other games that were previously hitting either of these two errors, feel free to try. ``[Debug] <Critical> spirv_emit_context.cpp:54 NumVertices: Unreachable code!`` ``[Debug] <Critical> emit_spirv.cpp:GetInputPrimitiveType:36: Unreachable code! Unknown input primitive type 10`` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:01:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2838
No description provided.