[PR #2566] [MERGED] Adding Top and Bottom trophy option for pop window + Trophy improvements #2829

New issue

Closed

opened 2026-02-27 22:01:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2566
Author: @diegolix29
Created: 2/28/2025
Status: ✅ Merged
Merged: 3/2/2025
Merged by: @georgemoralis

Base: main ← Head: top-trophy

📝 Commits (8)

ba556cb Adding top button option for trophy pop up
e26d5c5 Ui fix
f7e0af9 Clang format
dbbbf35 improvements to trophy pr
278e172 Merge branch 'shadps4-emu:main' into top-trophy
4d7a4ca centered text when using top and bottom option
3edb61b Clang
8e85f14 trophy viewer now opens in window not fullscreen

📊 Changes

9 files changed (+158 additions, -36 deletions)

View changed files

📝 src/common/config.cpp (+9 -8)
📝 src/common/config.h (+2 -2)
📝 src/common/path_util.cpp (+17 -1)
📝 src/core/libraries/np_trophy/trophy_ui.cpp (+39 -12)
📝 src/qt_gui/settings_dialog.cpp (+20 -4)
📝 src/qt_gui/settings_dialog.ui (+14 -6)
📝 src/qt_gui/translations/en_US.ts (+10 -2)
📝 src/qt_gui/trophy_viewer.cpp (+39 -1)
📝 src/qt_gui/trophy_viewer.h (+8 -0)

📄 Description

I always wanted the pop up to come from top as it will never overlap anything its more like a personal preference so feel free not to merge it if its unnecessary.

seems to be working ok on my end.

https://github.com/user-attachments/assets/b463a3fc-1230-402a-a9cb-2bf4a8a5ca6b

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2566 **Author:** [@diegolix29](https://github.com/diegolix29) **Created:** 2/28/2025 **Status:** ✅ Merged **Merged:** 3/2/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `top-trophy` --- ### 📝 Commits (8) - [`ba556cb`](https://github.com/shadps4-emu/shadPS4/commit/ba556cb4047ede07bae0303405e5237d9b77b560) Adding top button option for trophy pop up - [`e26d5c5`](https://github.com/shadps4-emu/shadPS4/commit/e26d5c5a7eeda9a4adb384940e60237c46688a82) Ui fix - [`f7e0af9`](https://github.com/shadps4-emu/shadPS4/commit/f7e0af96e5b67f4ea871e077a8ddda6f3a8a867c) Clang format - [`dbbbf35`](https://github.com/shadps4-emu/shadPS4/commit/dbbbf35d0936cdc4317589fc09a072a45077e29f) improvements to trophy pr - [`278e172`](https://github.com/shadps4-emu/shadPS4/commit/278e1724864549fa5272db2e742a731b0ea3d8eb) Merge branch 'shadps4-emu:main' into top-trophy - [`4d7a4ca`](https://github.com/shadps4-emu/shadPS4/commit/4d7a4caa618ab5c98a9780e828f7abf9ff014854) centered text when using top and bottom option - [`3edb61b`](https://github.com/shadps4-emu/shadPS4/commit/3edb61badd796bcc9f9f6f86d0e4cf4fd4e19923) Clang - [`8e85f14`](https://github.com/shadps4-emu/shadPS4/commit/8e85f149d9866c079cd3d1d42a0d5e9149967337) trophy viewer now opens in window not fullscreen ### 📊 Changes **9 files changed** (+158 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+9 -8) 📝 `src/common/config.h` (+2 -2) 📝 `src/common/path_util.cpp` (+17 -1) 📝 `src/core/libraries/np_trophy/trophy_ui.cpp` (+39 -12) 📝 `src/qt_gui/settings_dialog.cpp` (+20 -4) 📝 `src/qt_gui/settings_dialog.ui` (+14 -6) 📝 `src/qt_gui/translations/en_US.ts` (+10 -2) 📝 `src/qt_gui/trophy_viewer.cpp` (+39 -1) 📝 `src/qt_gui/trophy_viewer.h` (+8 -0) </details> ### 📄 Description I always wanted the pop up to come from top as it will never overlap anything its more like a personal preference so feel free not to merge it if its unnecessary. seems to be working ok on my end. ![image](https://github.com/user-attachments/assets/0e572c9d-6ec8-479d-969e-4c46c04ef551) https://github.com/user-attachments/assets/b463a3fc-1230-402a-a9cb-2bf4a8a5ca6b --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>