[PR #2535] [MERGED] cmake: Cleanup #2809

New issue

Closed

opened 2026-02-27 22:01:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2535
Author: @Osyotr
Created: 2/24/2025
Status: ✅ Merged
Merged: 2/25/2025
Merged by: @georgemoralis

Base: main ← Head: cmake-cleanup

📝 Commits (1)

c02ea77 cmake: Cleanup

📊 Changes

4 files changed (+16 additions, -7 deletions)

View changed files

📝 CMakeLists.txt (+2 -2)
📝 externals/CMakeLists.txt (+9 -2)
📝 externals/gcn/CMakeLists.txt (+5 -1)
➖ externals/gcn/dummy.cpp (+0 -2)

📄 Description

Don't call enable_language before project.
See CMake docs for CMP0165.
Remove boost-related cache variables.
It's too late to set them because Boost::headers has already been found.
Don't build SDL3-test library.
Not used by shadps4.
Remove /Zc:preprocessor from toml11's INTERFACE_COMPILE_OPTIONS.
Clang-cl does not support this flag and emits a lot of warnings.
Remove dummy.cpp and make gcn a proper INTERFACE target

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2535 **Author:** [@Osyotr](https://github.com/Osyotr) **Created:** 2/24/2025 **Status:** ✅ Merged **Merged:** 2/25/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `cmake-cleanup` --- ### 📝 Commits (1) - [`c02ea77`](https://github.com/shadps4-emu/shadPS4/commit/c02ea77b80c527a70ae93b546ac0d23882ce3c00) cmake: Cleanup ### 📊 Changes **4 files changed** (+16 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -2) 📝 `externals/CMakeLists.txt` (+9 -2) 📝 `externals/gcn/CMakeLists.txt` (+5 -1) ➖ `externals/gcn/dummy.cpp` (+0 -2) </details> ### 📄 Description - Don't call `enable_language` before `project`. See CMake docs for CMP0165. - Remove boost-related cache variables. It's too late to set them because `Boost::headers` has already been found. - Don't build `SDL3-test` library. Not used by shadps4. - Remove `/Zc:preprocessor` from toml11's `INTERFACE_COMPILE_OPTIONS`. Clang-cl does not support this flag and emits a lot of warnings. - Remove `dummy.cpp` and make `gcn` a proper `INTERFACE` target --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>