[PR #2522] [MERGED] Fix and add back Trophy type icons for both the trophy pop-up and viewer #2801

New issue

Closed

opened 2026-02-27 22:01:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2522
Author: @rainmakerv3
Created: 2/23/2025
Status: ✅ Merged
Merged: 2/24/2025
Merged by: @georgemoralis

Base: main ← Head: TrophyViewerIcons

📝 Commits (4)

9df29fd Add back fixed trophy type icons to trophy viewer
81f211a Remove unused declaration until it is needed again
f1cd552 Fix trophy pop-up icons
2c353d9 Adjust size and alignment based on trophy name length

📊 Changes

3 files changed (+72 additions, -18 deletions)

View changed files

📝 src/core/libraries/np_trophy/trophy_ui.cpp (+47 -7)
📝 src/qt_gui/trophy_viewer.cpp (+11 -11)
📝 src/qt_gui/trophy_viewer.h (+14 -0)

📄 Description

Fixes and adds back the type icons in the trophy viewer. Does not include the trophy pop-up icons yet, that one is a bit more complicated.

*Should be working now, but would like some tests from other people to be sure

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2522 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 2/23/2025 **Status:** ✅ Merged **Merged:** 2/24/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `TrophyViewerIcons` --- ### 📝 Commits (4) - [`9df29fd`](https://github.com/shadps4-emu/shadPS4/commit/9df29fdc316092dd06e0ac7afda530e4cf056ff8) Add back fixed trophy type icons to trophy viewer - [`81f211a`](https://github.com/shadps4-emu/shadPS4/commit/81f211a82af1b5c9da6ee16434e9d3f1685a8c72) Remove unused declaration until it is needed again - [`f1cd552`](https://github.com/shadps4-emu/shadPS4/commit/f1cd552f05cd8d544e8c40a82538270b5f5c40c1) Fix trophy pop-up icons - [`2c353d9`](https://github.com/shadps4-emu/shadPS4/commit/2c353d9a206cbddd01d2d36cd15423ff2a701dc1) Adjust size and alignment based on trophy name length ### 📊 Changes **3 files changed** (+72 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/np_trophy/trophy_ui.cpp` (+47 -7) 📝 `src/qt_gui/trophy_viewer.cpp` (+11 -11) 📝 `src/qt_gui/trophy_viewer.h` (+14 -0) </details> ### 📄 Description Fixes and adds back the type icons in the trophy viewer. Does not include the trophy pop-up icons yet, that one is a bit more complicated. *Should be working now, but would like some tests from other people to be sure ![image](https://github.com/user-attachments/assets/5f497e6c-1dcc-45e2-95be-51fb8a096f7a) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>