[PR #2509] [MERGED] Revert use of embedded icons #2788

New issue

Closed

opened 2026-02-27 22:01:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2509
Author: @rainmakerv3
Created: 2/23/2025
Status: ✅ Merged
Merged: 2/23/2025
Merged by: @georgemoralis

Base: main ← Head: trophyTempFix

📝 Commits (1)

6f60c72 Revert use of embedded icons

📊 Changes

3 files changed (+15 additions, -61 deletions)

View changed files

📝 src/core/libraries/np_trophy/trophy_ui.cpp (+4 -35)
📝 src/qt_gui/trophy_viewer.cpp (+11 -12)
📝 src/qt_gui/trophy_viewer.h (+0 -14)

📄 Description

So the embedded icons in https://github.com/shadps4-emu/shadPS4/pull/2493 are broken for a lot of people, and it does not look like an easy fix, This reverts the use of the embedded icons temporarily while I work on it, still keeping the other fixes in the PR

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2509 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 2/23/2025 **Status:** ✅ Merged **Merged:** 2/23/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `trophyTempFix` --- ### 📝 Commits (1) - [`6f60c72`](https://github.com/shadps4-emu/shadPS4/commit/6f60c721d690a05c9cf60a225dc1c990725f0168) Revert use of embedded icons ### 📊 Changes **3 files changed** (+15 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/np_trophy/trophy_ui.cpp` (+4 -35) 📝 `src/qt_gui/trophy_viewer.cpp` (+11 -12) 📝 `src/qt_gui/trophy_viewer.h` (+0 -14) </details> ### 📄 Description So the embedded icons in https://github.com/shadps4-emu/shadPS4/pull/2493 are broken for a lot of people, and it does not look like an easy fix, This reverts the use of the embedded icons temporarily while I work on it, still keeping the other fixes in the PR --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>