[PR #2491] [MERGED] libcInternal HLE fixes #2778

New issue

Closed

opened 2026-02-27 22:01:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2491
Author: @georgemoralis
Created: 2/21/2025
Status: ✅ Merged
Merged: 2/22/2025
Merged by: @georgemoralis

Base: main ← Head: libcinternal_fixes

📝 Commits (4)

a4a8bf7 internal_vprintf was wrong
54b13e6 reducing the calls to only needed (and tested one) . Fixed strcpy_s
f758982 clang fix
43a8b13 Added snprintf

📊 Changes

11 files changed (+880 additions, -21545 deletions)

View changed files

📝 CMakeLists.txt (+3 -6)
📝 src/core/libraries/libc_internal/libc_internal.cpp (+11 -16240)
📝 src/core/libraries/libc_internal/libc_internal_io.cpp (+6 -454)
📝 src/core/libraries/libc_internal/libc_internal_math.cpp (+61 -678)
📝 src/core/libraries/libc_internal/libc_internal_memory.cpp (+9 -278)
➖ src/core/libraries/libc_internal/libc_internal_mspace.cpp (+0 -247)
➖ src/core/libraries/libc_internal/libc_internal_mspace.h (+0 -14)
📝 src/core/libraries/libc_internal/libc_internal_str.cpp (+27 -475)
➖ src/core/libraries/libc_internal/libc_internal_stream.cpp (+0 -3139)
➖ src/core/libraries/libc_internal/libc_internal_stream.h (+0 -14)
➕ src/core/libraries/libc_internal/printf.h (+763 -0)

📄 Description

-internal_vprintf was wrong (commented for now i will provide a fix one)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2491 **Author:** [@georgemoralis](https://github.com/georgemoralis) **Created:** 2/21/2025 **Status:** ✅ Merged **Merged:** 2/22/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `libcinternal_fixes` --- ### 📝 Commits (4) - [`a4a8bf7`](https://github.com/shadps4-emu/shadPS4/commit/a4a8bf721b018bfd324620e2aec22c9a57c02a86) internal_vprintf was wrong - [`54b13e6`](https://github.com/shadps4-emu/shadPS4/commit/54b13e67edf102d978bd2109d350cb28a4d10fe8) reducing the calls to only needed (and tested one) . Fixed strcpy_s - [`f758982`](https://github.com/shadps4-emu/shadPS4/commit/f758982964b263df6778aeb7625aae84d6e50136) clang fix - [`43a8b13`](https://github.com/shadps4-emu/shadPS4/commit/43a8b13371d716ae9eea357fb45fc9ad2a97eb39) Added snprintf ### 📊 Changes **11 files changed** (+880 additions, -21545 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+3 -6) 📝 `src/core/libraries/libc_internal/libc_internal.cpp` (+11 -16240) 📝 `src/core/libraries/libc_internal/libc_internal_io.cpp` (+6 -454) 📝 `src/core/libraries/libc_internal/libc_internal_math.cpp` (+61 -678) 📝 `src/core/libraries/libc_internal/libc_internal_memory.cpp` (+9 -278) ➖ `src/core/libraries/libc_internal/libc_internal_mspace.cpp` (+0 -247) ➖ `src/core/libraries/libc_internal/libc_internal_mspace.h` (+0 -14) 📝 `src/core/libraries/libc_internal/libc_internal_str.cpp` (+27 -475) ➖ `src/core/libraries/libc_internal/libc_internal_stream.cpp` (+0 -3139) ➖ `src/core/libraries/libc_internal/libc_internal_stream.h` (+0 -14) ➕ `src/core/libraries/libc_internal/printf.h` (+763 -0) </details> ### 📄 Description -internal_vprintf was wrong (commented for now i will provide a fix one) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>