[PR #2458] [MERGED] renderer_vulkan: Bind descriptors to specific stages in layout. #2750

New issue

Closed

opened 2026-02-27 22:01:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2458
Author: @squidbus
Created: 2/16/2025
Status: ✅ Merged
Merged: 2/16/2025
Merged by: @raphaelthegreat

Base: main ← Head: desc-stage

📝 Commits (1)

96c98e3 renderer_vulkan: Bind descriptors to specific stages in layout.

📊 Changes

3 files changed (+16 additions, -6 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+14 -4)
📝 src/video_core/renderer_vulkan/vk_pipeline_common.cpp (+1 -1)
📝 src/video_core/renderer_vulkan/vk_pipeline_common.h (+1 -1)

📄 Description

When defining descriptor set layouts, instead of attaching descriptors to all stages, attach only to the stage they came from.

This reduces the per-stage binding pressure, which can help MoltenVK in particular when using push descriptors to have enough binding slots for its own internal buffers for purposes like tessellation data.

Should fix https://github.com/shadps4-emu/shadPS4/issues/1820

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2458 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 2/16/2025 **Status:** ✅ Merged **Merged:** 2/16/2025 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `desc-stage` --- ### 📝 Commits (1) - [`96c98e3`](https://github.com/shadps4-emu/shadPS4/commit/96c98e3c0131a135c5ef3a8555b8417ed935aee0) renderer_vulkan: Bind descriptors to specific stages in layout. ### 📊 Changes **3 files changed** (+16 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+14 -4) 📝 `src/video_core/renderer_vulkan/vk_pipeline_common.cpp` (+1 -1) 📝 `src/video_core/renderer_vulkan/vk_pipeline_common.h` (+1 -1) </details> ### 📄 Description When defining descriptor set layouts, instead of attaching descriptors to all stages, attach only to the stage they came from. This reduces the per-stage binding pressure, which can help MoltenVK in particular when using push descriptors to have enough binding slots for its own internal buffers for purposes like tessellation data. Should fix https://github.com/shadps4-emu/shadPS4/issues/1820 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>