[PR #2439] [MERGED] More fixes to make the translation work #2735

New issue

Closed

opened 2026-02-27 22:01:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2439
Author: @DanielSvoboda
Created: 2/14/2025
Status: ✅ Merged
Merged: 2/15/2025
Merged by: @georgemoralis

Base: main ← Head: main

📝 Commits (3)

8b35728 more fixes to make the translation work
245255e If size is disabled, it will not appear on the patches screen
9c866a8 Update game_install_dialog.h

📊 Changes

3 files changed (+11 additions, -8 deletions)

View changed files

📝 src/qt_gui/cheats_patches.cpp (+5 -3)
📝 src/qt_gui/game_install_dialog.h (+1 -0)
📝 src/qt_gui/settings_dialog.cpp (+5 -5)

📄 Description

I ended up getting confused with these tags in https://github.com/shadps4-emu/shadPS4/pull/2426
& apos;
& quot;
So some translations were not being localized, this should solve it

If size is disabled, it will not appear on the patches screen

added 'Q_OBJECT' to this screen to show the translation

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2439 **Author:** [@DanielSvoboda](https://github.com/DanielSvoboda) **Created:** 2/14/2025 **Status:** ✅ Merged **Merged:** 2/15/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`8b35728`](https://github.com/shadps4-emu/shadPS4/commit/8b35728962bbf56c400b6b18c97eb5a64827fcf7) more fixes to make the translation work - [`245255e`](https://github.com/shadps4-emu/shadPS4/commit/245255e814dcfa422df5676da3214c57468be16d) If size is disabled, it will not appear on the patches screen - [`9c866a8`](https://github.com/shadps4-emu/shadPS4/commit/9c866a84680de06b4e93a4498ea8fc9117e444d9) Update game_install_dialog.h ### 📊 Changes **3 files changed** (+11 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/cheats_patches.cpp` (+5 -3) 📝 `src/qt_gui/game_install_dialog.h` (+1 -0) 📝 `src/qt_gui/settings_dialog.cpp` (+5 -5) </details> ### 📄 Description I ended up getting confused with these tags in https://github.com/shadps4-emu/shadPS4/pull/2426 & apos; & quot; So some translations were not being localized, this should solve it ---- If size is disabled, it will not appear on the patches screen ![image](https://github.com/user-attachments/assets/45cc0c6e-9799-4da3-9f6e-a02038070d00) ---- added 'Q_OBJECT' to this screen to show the translation ![image](https://github.com/user-attachments/assets/fc0cd06b-f603-4da9-b66d-87f509a3aa87) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>