[PR #2404] [MERGED] memory: Log for sceKernelMapNamedDirectMemory in more cases. #2706

New issue

Closed

opened 2026-02-27 22:00:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2404
Author: @squidbus
Created: 2/12/2025
Status: ✅ Merged
Merged: 2/12/2025
Merged by: @georgemoralis

Base: main ← Head: mem-log

📝 Commits (1)

032a18d memory: Log for sceKernelMapNamedDirectMemory in more cases.

📊 Changes

1 file changed (+11 additions, -9 deletions)

View changed files

📝 src/core/libraries/kernel/memory.cpp (+11 -9)

📄 Description

Moves logging of input parameters in sceKernelMapNamedDirectMemory up to the top, to make sure they still get logged in the case of an invalid input or an assert while mapping memory. It has been difficult with this function to tell what caused a particular crash because none of the actual inputs get logged.

Also, moved the output address logging out of SCOPE_EXIT, as this is causing it to confusingly log with operator() instead of the actual function name.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2404 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 2/12/2025 **Status:** ✅ Merged **Merged:** 2/12/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `mem-log` --- ### 📝 Commits (1) - [`032a18d`](https://github.com/shadps4-emu/shadPS4/commit/032a18d076250d4f8b06a944091938ada7192257) memory: Log for sceKernelMapNamedDirectMemory in more cases. ### 📊 Changes **1 file changed** (+11 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/kernel/memory.cpp` (+11 -9) </details> ### 📄 Description Moves logging of input parameters in `sceKernelMapNamedDirectMemory` up to the top, to make sure they still get logged in the case of an invalid input or an assert while mapping memory. It has been difficult with this function to tell what caused a particular crash because none of the actual inputs get logged. Also, moved the output address logging out of `SCOPE_EXIT`, as this is causing it to confusingly log with `operator()` instead of the actual function name. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>