[PR #2388] [MERGED] fix: lower UBO max size to account buffer cache offset #2695

New issue

Closed

opened 2026-02-27 22:00:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2388
Author: @psucien
Created: 2/9/2025
Status: ✅ Merged
Merged: 2/9/2025
Merged by: @psucien

Base: main ← Head: fix/ubo_desc_size

📝 Commits (3)

7c9bd08 fix: lower UBO max size to account buffer cache offset
9865692 review comments
4323a4c remove UBO size from spec and always set it to max on shader side

📊 Changes

14 files changed (+61 additions, -40 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+2 -2)
📝 src/shader_recompiler/info.h (+4 -4)
📝 src/shader_recompiler/profile.h (+1 -0)
📝 src/shader_recompiler/specialization.h (+5 -10)
📝 src/video_core/renderer_vulkan/vk_compute_pipeline.cpp (+8 -7)
📝 src/video_core/renderer_vulkan/vk_compute_pipeline.h (+3 -2)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+7 -6)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+2 -1)
📝 src/video_core/renderer_vulkan/vk_instance.h (+7 -0)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+8 -3)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.h (+4 -0)
📝 src/video_core/renderer_vulkan/vk_pipeline_common.cpp (+4 -2)
📝 src/video_core/renderer_vulkan/vk_pipeline_common.h (+4 -1)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+2 -2)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2388 **Author:** [@psucien](https://github.com/psucien) **Created:** 2/9/2025 **Status:** ✅ Merged **Merged:** 2/9/2025 **Merged by:** [@psucien](https://github.com/psucien) **Base:** `main` ← **Head:** `fix/ubo_desc_size` --- ### 📝 Commits (3) - [`7c9bd08`](https://github.com/shadps4-emu/shadPS4/commit/7c9bd08df9bed2f364acf234c1371c6065c75924) fix: lower UBO max size to account buffer cache offset - [`9865692`](https://github.com/shadps4-emu/shadPS4/commit/9865692d355c9fb89c1a8f39b6031d55faf545eb) review comments - [`4323a4c`](https://github.com/shadps4-emu/shadPS4/commit/4323a4c31de8ef7a78c75e169b348bf80999da91) remove UBO size from spec and always set it to max on shader side ### 📊 Changes **14 files changed** (+61 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+2 -2) 📝 `src/shader_recompiler/info.h` (+4 -4) 📝 `src/shader_recompiler/profile.h` (+1 -0) 📝 `src/shader_recompiler/specialization.h` (+5 -10) 📝 `src/video_core/renderer_vulkan/vk_compute_pipeline.cpp` (+8 -7) 📝 `src/video_core/renderer_vulkan/vk_compute_pipeline.h` (+3 -2) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+7 -6) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+2 -1) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+7 -0) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+8 -3) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.h` (+4 -0) 📝 `src/video_core/renderer_vulkan/vk_pipeline_common.cpp` (+4 -2) 📝 `src/video_core/renderer_vulkan/vk_pipeline_common.h` (+4 -1) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+2 -2) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>